|SUCCESS| [4/4] net/cpfl: demote path selection logs from NOTICE to DEBUG

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163214

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-20

I'll review this patch series focusing on correctness, C coding style, and guideline compliance.

---

**Commit:** 872b57178709 / cf96ec231d02 (and similar)
**Author:** Shaiq Wani <shaiq.wani at intel.com>
**Subject:** net/ice: demote path selection logs from NOTICE to DEBUG

This patch series demotes Rx/Tx path selection log messages from NOTICE
to DEBUG level across multiple Intel network drivers (ice, iavf, idpf,
cpfl).

> diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
> index 31b74be9ba..5edbd705a3 100644
> --- a/drivers/net/intel/ice/ice_rxtx.c
> +++ b/drivers/net/intel/ice/ice_rxtx.c
> @@ -3408,7 +3408,7 @@ ice_set_rx_function(struct rte_eth_dev *dev)
>  
>  out:
>  	dev->rx_pkt_burst = ice_rx_path_infos[ad->rx_func_type].pkt_burst;
> -	PMD_DRV_LOG(NOTICE, "Using %s (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s (port %d).",
>  			ice_rx_path_infos[ad->rx_func_type].info, dev->data->port_id);
>  }

The change from NOTICE to DEBUG level is a policy decision. Was this
change discussed with the maintainers? Path selection information can be
valuable for deployment debugging and might be intentionally set to
NOTICE level for production visibility. Does reducing these messages to
DEBUG level align with the driver's logging policy?

[ ... ]

> diff --git a/drivers/net/intel/iavf/iavf_rxtx.c b/drivers/net/intel/iavf/iavf_rxtx.c
> index 4ff6c18dc4..3d9b49efd0 100644
> --- a/drivers/net/intel/iavf/iavf_rxtx.c
> +++ b/drivers/net/intel/iavf/iavf_rxtx.c
> @@ -3856,7 +3856,7 @@ iavf_set_rx_function(struct rte_eth_dev *dev)
>  	else
>  		dev->rx_pkt_burst = iavf_rx_path_infos[adapter->rx_func_type].pkt_burst;
>  
> -	PMD_DRV_LOG(NOTICE, "Using %s (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s (port %d).",
>  		iavf_rx_path_infos[adapter->rx_func_type].info, dev->data->port_id);
>  }

Same question applies here - was the log level policy change discussed?

[ ... ]

> diff --git a/drivers/net/intel/idpf/idpf_rxtx.c b/drivers/net/intel/idpf/idpf_rxtx.c
> index b316c77b62..20cfc3a506 100644
> --- a/drivers/net/intel/idpf/idpf_rxtx.c
> +++ b/drivers/net/intel/idpf/idpf_rxtx.c
> @@ -835,7 +835,7 @@ idpf_set_rx_function(struct rte_eth_dev *dev)
>  
>  out:
>  	dev->rx_pkt_burst = idpf_rx_path_infos[ad->rx_func_type].pkt_burst;
> -	PMD_DRV_LOG(NOTICE, "Using %s Rx (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s Rx (port %d).",
>  			idpf_rx_path_infos[ad->rx_func_type].info, dev->data->port_id);
>  
>  }
> @@ -902,6 +902,6 @@ idpf_set_tx_function(struct rte_eth_dev *dev)
>  out:
>  	dev->tx_pkt_burst = idpf_tx_path_infos[ad->tx_func_type].pkt_burst;
>  	dev->tx_pkt_prepare = idpf_dp_prep_pkts;
> -	PMD_DRV_LOG(NOTICE, "Using %s Tx (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s Tx (port %d).",
>  			idpf_tx_path_infos[ad->tx_func_type].info, dev->data->port_id);
>  }

Consistency question: All four drivers are being modified identically.
Are all these drivers maintained by the same team, and was this policy
change coordinated across all affected drivers?

>From a technical perspective, the patches themselves appear correct:
- No resource management changes
- No functional logic changes
- Only log level modifications
- Coding style preserved

However, the commit messages state this change reduces noise. For
operational deployments, path selection information during device
initialization might be important diagnostics that operators expect to
see at NOTICE level. Has the impact on production debugging been
considered?