|SUCCESS| [4/4] net/cpfl: demote path selection logs from NOTICE to DEBUG

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163214

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-20

Reviewing patch series changing log levels from NOTICE to DEBUG in Intel network drivers.

Patch 1/4: net/ice: demote path selection logs from NOTICE to DEBUG
Author: Shaiq Wani <shaiq.wani at intel.com>

This patch demotes Rx/Tx path selection log messages from NOTICE to
DEBUG level in the ice driver.

> diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
> index 31b74be9ba..5edbd705a3 100644
> --- a/drivers/net/intel/ice/ice_rxtx.c
> +++ b/drivers/net/intel/ice/ice_rxtx.c
> @@ -3408,7 +3408,7 @@ ice_set_rx_function(struct rte_eth_dev *dev)
>  
>  out:
>  	dev->rx_pkt_burst = ice_rx_path_infos[ad->rx_func_type].pkt_burst;
> -	PMD_DRV_LOG(NOTICE, "Using %s (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s (port %d).",
>  			ice_rx_path_infos[ad->rx_func_type].info, dev->data->port_id);
>  }

Does this code have alignment issues with the continuation line? The
continuation should be aligned with the opening parenthesis of the
function call.

> @@ -3735,7 +3735,7 @@ ice_set_tx_function(struct rte_eth_dev *dev)
>  	dev->tx_pkt_burst = mbuf_check ? ice_xmit_pkts_check :
>  					 ice_tx_path_infos[ad->tx_func_type].pkt_burst;
>  	dev->tx_pkt_prepare = ice_tx_path_infos[ad->tx_func_type].pkt_prep;
> -	PMD_DRV_LOG(NOTICE, "Using %s (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s (port %d).",
>  		ice_tx_path_infos[ad->tx_func_type].info, dev->data->port_id);
>  }

Same alignment concern here with the continuation line.

---

Patch 2/4: net/iavf: demote path selection logs from NOTICE to DEBUG
Author: Shaiq Wani <shaiq.wani at intel.com>

This patch demotes Rx/Tx path selection log messages from NOTICE to
DEBUG level in the iavf driver.

> diff --git a/drivers/net/intel/iavf/iavf_rxtx.c b/drivers/net/intel/iavf/iavf_rxtx.c
> index 4ff6c18dc4..3d9b49efd0 100644
> --- a/drivers/net/intel/iavf/iavf_rxtx.c
> +++ b/drivers/net/intel/iavf/iavf_rxtx.c
> @@ -3856,7 +3856,7 @@ iavf_set_rx_function(struct rte_eth_dev *dev)
>  	else
>  		dev->rx_pkt_burst = iavf_rx_path_infos[adapter->rx_func_type].pkt_burst;
>  
> -	PMD_DRV_LOG(NOTICE, "Using %s (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s (port %d).",
>  		iavf_rx_path_infos[adapter->rx_func_type].info, dev->data->port_id);
>  }

Does this continuation line need proper alignment with the opening
parenthesis?

> @@ -3923,7 +3923,7 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
>  	else
>  		dev->tx_pkt_burst = iavf_tx_path_infos[adapter->tx_func_type].pkt_burst;
>  
> -	PMD_DRV_LOG(NOTICE, "Using %s (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s (port %d).",
>  		 iavf_tx_path_infos[adapter->tx_func_type].info, dev->data->port_id);
>  }

Does this continuation line have extra space before the argument? It
appears to have inconsistent indentation compared to the Rx function.

---

Patch 3/4: net/idpf: demote path selection logs from NOTICE to DEBUG
Author: Shaiq Wani <shaiq.wani at intel.com>

This patch demotes Rx/Tx path selection log messages from NOTICE to
DEBUG level in the idpf driver.

> diff --git a/drivers/net/intel/idpf/idpf_rxtx.c b/drivers/net/intel/idpf/idpf_rxtx.c
> index b316c77b62..20cfc3a506 100644
> --- a/drivers/net/intel/idpf/idpf_rxtx.c
> +++ b/drivers/net/intel/idpf/idpf_rxtx.c
> @@ -835,7 +835,7 @@ idpf_set_rx_function(struct rte_eth_dev *dev)
>  
>  out:
>  	dev->rx_pkt_burst = idpf_rx_path_infos[ad->rx_func_type].pkt_burst;
> -	PMD_DRV_LOG(NOTICE, "Using %s Rx (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s Rx (port %d).",
>  			idpf_rx_path_infos[ad->rx_func_type].info, dev->data->port_id);
>  
>  }

Does this continuation line follow the correct alignment pattern?

> @@ -902,6 +902,6 @@ idpf_set_tx_function(struct rte_eth_dev *dev)
>  out:
>  	dev->tx_pkt_burst = idpf_tx_path_infos[ad->tx_func_type].pkt_burst;
>  	dev->tx_pkt_prepare = idpf_dp_prep_pkts;
> -	PMD_DRV_LOG(NOTICE, "Using %s Tx (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s Tx (port %d).",
>  			idpf_tx_path_infos[ad->tx_func_type].info, dev->data->port_id);
>  }

Same alignment question here.

---

Patch 4/4: net/cpfl: demote path selection logs from NOTICE to DEBUG
Author: Shaiq Wani <shaiq.wani at intel.com>

This patch demotes Rx/Tx path selection log messages from NOTICE to
DEBUG level in the cpfl driver.

> diff --git a/drivers/net/intel/cpfl/cpfl_rxtx.c b/drivers/net/intel/cpfl/cpfl_rxtx.c
> index ad622b267d..bbf8225d54 100644
> --- a/drivers/net/intel/cpfl/cpfl_rxtx.c
> +++ b/drivers/net/intel/cpfl/cpfl_rxtx.c
> @@ -1487,7 +1487,7 @@ cpfl_set_rx_function(struct rte_eth_dev *dev)
>  
>  out:
>  	dev->rx_pkt_burst = idpf_rx_path_infos[ad->rx_func_type].pkt_burst;
> -	PMD_DRV_LOG(NOTICE, "Using %s Rx (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s Rx (port %d).",
>  			idpf_rx_path_infos[ad->rx_func_type].info, dev->data->port_id);
>  
>  }

Does this continuation line need alignment adjustment?

> @@ -1556,6 +1556,6 @@ cpfl_set_tx_function(struct rte_eth_dev *dev)
>  out:
>  	dev->tx_pkt_burst = idpf_tx_path_infos[ad->tx_func_type].pkt_burst;
>  	dev->tx_pkt_prepare = idpf_dp_prep_pkts;
> -	PMD_DRV_LOG(NOTICE, "Using %s Tx (port %d).",
> +	PMD_DRV_LOG(DEBUG, "Using %s Tx (port %d).",
>  			idpf_tx_path_infos[ad->tx_func_type].info, dev->data->port_id);
>  }

Same alignment question here.