|WARNING| [v3, 3/3] common/sfc_efx/base: switch netport stats to use EVB port ID

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167778

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-14

# DPDK Patch Review

## Patch 1/3: common/sfc_efx/base: update MCDI headers

**No issues found.**

This patch is a mechanical import of MCDI header changes from the upstream vendor repository.
It adds new statistics IDs, comments, and field definitions.
These are header-only changes with no executable code or API changes.

---

## Patch 2/3: common/sfc_efx/base: add support for VADAPTER statistics IDs

**No issues found.**

This patch adds VADAPTER statistics mapping entries to an existing statistics map array.
The pattern matches the existing `EFX_NP_STAT_MAC` and `EFX_NP_STAT_PHY` entries already present in the file.
All added entries are compile-time constant data.

---

## Patch 3/3: common/sfc_efx/base: switch netport stats to use EVB port ID

### Errors

None.

### Warnings

**Function signature change without ABI consideration** (Warning):
The patch changes the signature of `efx_np_mac_stats()` by reordering parameters and adding a new `vport_id` parameter:
```c
/* Before */
efx_np_mac_stats(enp, nph, action, esmp, period_ms);

/* After */
efx_np_mac_stats(enp, nph, vport_id, esmp, action, period_ms);
```

This is an internal function (`efx_impl.h` is not an installed header),
so it does not break public ABI.
However, if this function is used by other code not visible in this patch series,
those call sites would need to be updated.
The patch updates all visible call sites in `efx_mcdi.c` and `medford4_mac.c`.

**Clarity**: The commit message states this change "adjusts the argument order for efx_np_mac_stats to match the legacy efx_mcdi_mac_stats,"
but the new order is actually different from `efx_mcdi_mac_stats(enp, vport_id, esmp, action, period_ms)`
-- the `nph` handle is inserted after `enp`.
This is acceptable (the netport variant needs the handle parameter),
but the commit message could be more precise.

### Info

None.

---

## Overall Assessment

This patch series is a clean vendor code import and integration.
The code changes are straightforward and follow existing patterns in the codebase.
All changes are confined to the `drivers/common/sfc_efx/base/` directory,
which is a driver base directory (vendor code), and appropriately uses vendor naming conventions
per the exception in the AGENTS.md naming guidelines.

The series does not introduce new public API, does not require release notes
(driver-internal changes), and does not modify any test or documentation files
(appropriate for a low-level driver update).