|WARNING| [v3, 3/3] common/sfc_efx/base: switch netport stats to use EVB port ID

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167778

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-14

# DPDK Patch Review

## Patch 1/3: common/sfc_efx/base: update MCDI headers

### Errors

None identified.

### Warnings

None identified.

### Info

This patch updates MCDI header definitions imported from the vendor's upstream repository. The changes are mechanical additions of new statistics identifiers, command field definitions, and documentation clarifications. The code is under `drivers/common/sfc_efx/base/`, which is vendor-supplied code exempt from most DPDK style rules per the guidelines.

---

## Patch 2/3: common/sfc_efx/base: add support for VADAPTER statistics IDs

### Errors

None identified.

### Warnings

None identified.

### Info

This patch adds mappings for VADAPTER statistics using the same pattern already established in the file. The additions are consistent with existing code style in the base driver directory.

---

## Patch 3/3: common/sfc_efx/base: switch netport stats to use EVB port ID

### Errors

None identified.

### Warnings

**Warning**: Argument order change in `efx_np_mac_stats()` is an internal API modification.

The patch changes the argument order of `efx_np_mac_stats()` to insert `vport_id` and reorder `action` relative to `esmp`. While this is an internal function (not part of the public DPDK API), it affects multiple call sites across the driver. The commit message states this is "for clarity" to match the legacy `efx_mcdi_mac_stats()` order, which is a reasonable justification.

All call sites are updated in the same patch:
- `efx_mcdi.c`: `efx_mcdi_mac_stats_clear()`
- `medford4_mac.c`: `medford4_mac_stats_upload()`, `medford4_mac_stats_periodic()`

This is acceptable as an internal refactor within the driver, but should be noted for maintainer awareness.

### Info

The patch correctly updates the MCDI command from `GET_NETPORT_STATISTICS` to `GET_NETPORT_STATISTICS_V2` to pass the EVB port ID for VADAPTER statistics support. The comment added about not using `EVB_PORT_ID_ASSIGNED` when disabling periodic stats provides useful context for the conditional vport_id assignment.

---

## Summary

**Overall Assessment**: The patch series is correct and introduces no coding standard violations or correctness bugs. All changes are confined to the vendor-supplied base driver code under `drivers/common/sfc_efx/base/`, which is exempt from most DPDK style requirements. The internal API reordering in patch 3/3 is acceptable given all call sites are updated atomically in the same patch.

**Recommendation**: Acceptable for merge, with the internal API change noted for maintainer review.