|WARNING| pw160661 [PATCH 7/7] net/hinic3: use different callback func to support htn fdir

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/160661

_coding style issues_


WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#109: FILE: drivers/net/hinic3/base/hinic3_nic_cfg.c:1470:
+								 struct hinic3_ethertype_filter *ethertype_filter,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#122: FILE: drivers/net/hinic3/base/hinic3_nic_cfg.c:1482:
+	nic_dev = (struct hinic3_nic_dev*)hwdev->dev_handle;

CHECK:BRACES: braces {} should be used on all arms of this statement
#124: FILE: drivers/net/hinic3/base/hinic3_nic_cfg.c:1484:
+	if ((hinic3_get_driver_feature(nic_dev) & NIC_F_HTN_FDIR) != 0)
[...]
+	} else {
[...]

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 24)
#127: FILE: drivers/net/hinic3/base/hinic3_nic_cfg.c:1487:
+			if (index == HINIC3_TCAM_INVALID_INDEX) {
+			return -ENOMEM;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#127: FILE: drivers/net/hinic3/base/hinic3_nic_cfg.c:1487:
+			if (index == HINIC3_TCAM_INVALID_INDEX) {
+			return -ENOMEM;
+		}

WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#182: FILE: drivers/net/hinic3/base/hinic3_nic_cfg.h:1542:
+									 struct hinic3_ethertype_filter *ethertype_filter,

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#589: FILE: drivers/net/hinic3/hinic3_fdir.c:612:
+									&rule->key_spec.ipv4, tcam_key);

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#600: FILE: drivers/net/hinic3/hinic3_fdir.c:623:
+								&rule->key_spec.inner_ipv4, tcam_key);

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#649: FILE: drivers/net/hinic3/hinic3_fdir.c:672:
+	tcam_key->key_info_htn.function_id_l = hinic3_global_func_id(nic_dev->hwdev) & HINIC3_UINT5_MAX;

ERROR:CODE_INDENT: code indent should use tabs where possible
#688: FILE: drivers/net/hinic3/hinic3_fdir.c:737:
+^I^I^I  ^I^I^I  struct hinic3_tcam_key *key,$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#688: FILE: drivers/net/hinic3/hinic3_fdir.c:737:
+^I^I^I  ^I^I^I  struct hinic3_tcam_key *key,$

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#698: FILE: drivers/net/hinic3/hinic3_fdir.c:743:
+		TAILQ_FOREACH (it, filter_list, entries) {

WARNING:LONG_LINE: line length of 166 exceeds 100 columns
#705: FILE: drivers/net/hinic3/hinic3_fdir.c:750:
+																			== tcam_index)

ERROR:SPACING: spaces required around that '==' (ctx:WxV)
#818: FILE: drivers/net/hinic3/hinic3_fdir.c:956:
+	if (tmp->dynamic_index_cnt ==0) {
 	                           ^

WARNING:LONG_LINE: line length of 131 exceeds 100 columns
#876: FILE: drivers/net/hinic3/hinic3_fdir.c:997:
+														tcam_filter->index;

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#955: FILE: drivers/net/hinic3/hinic3_fdir.c:1166:
+								HINIC3_ACTION_ADD, HINIC3_INVALID_INDEX);

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#964: FILE: drivers/net/hinic3/hinic3_fdir.c:1188:
+							HINIC3_ACTION_NOT_ADD, fdir_filter->tcam_index);

WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#1630: FILE: drivers/net/hinic3/hinic3_fdir.h:613:
+	TAILQ_ENTRY(hinic3_tcam_filter) entries; /**< Filter entry, used for linked list operations. */

total: 3 errors, 14 warnings, 1 checks, 1532 lines checked