|WARNING| pw160658 [PATCH 6/7] net/hinic3: add tx ops to support Compact CQE

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Jan 31 11:08:55 CET 2026

Previous message (by thread): |WARNING| pw160661 [PATCH 7/7] net/hinic3: use different callback func to support htn fdir
Next message (by thread): |WARNING| pw160657 [PATCH 5/7] net/hinic3: add rx ops to support Compact CQE
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/160658

_coding style issues_


WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#81: FILE: drivers/net/hinic3/hinic3_ethdev.h:103:
+										  struct hinic3_sq_wqe_combo *wqe_combo);

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#268: FILE: drivers/net/hinic3/hinic3_tx.c:348:
+								  struct hinic3_sq_wqe_combo *wqe_combo)

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#289: FILE: drivers/net/hinic3/hinic3_tx.c:366:
+							 SQ_TASK_INFO3_SET(offload_info->vlan_sel, VLAN_TYPE) |

WARNING:LONG_LINE: line length of 117 exceeds 100 columns
#290: FILE: drivers/net/hinic3/hinic3_tx.c:367:
+							 SQ_TASK_INFO3_SET(offload_info->vlan_valid, VLAN_TAG_VALID);

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#312: FILE: drivers/net/hinic3/hinic3_tx.c:374:
+								   struct hinic3_sq_wqe_combo *wqe_combo)

ERROR:TRAILING_WHITESPACE: trailing whitespace
#452: FILE: drivers/net/hinic3/hinic3_tx.c:489:
+^I/* Calculate the number of message payload frag, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#484: FILE: drivers/net/hinic3/hinic3_tx.c:573:
+^I/* $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#494: FILE: drivers/net/hinic3/hinic3_tx.c:583:
+^I/* $

ERROR:CODE_INDENT: code indent should use tabs where possible
#649: FILE: drivers/net/hinic3/hinic3_tx.c:834:
+^I^I^I^I      ^I^I  SQ_CTRL_SET(wqe_combo->task_type, TASKSECT_LEN) |$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#649: FILE: drivers/net/hinic3/hinic3_tx.c:834:
+^I^I^I^I      ^I^I  SQ_CTRL_SET(wqe_combo->task_type, TASKSECT_LEN) |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#650: FILE: drivers/net/hinic3/hinic3_tx.c:835:
+^I^I^I^I      ^I^I  SQ_CTRL_SET(SQ_WQE_SGL, DATA_FORMAT);$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#650: FILE: drivers/net/hinic3/hinic3_tx.c:835:
+^I^I^I^I      ^I^I  SQ_CTRL_SET(SQ_WQE_SGL, DATA_FORMAT);$

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#671: FILE: drivers/net/hinic3/hinic3_tx.c:856:
+			    		SQ_CTRL_COMPACT_QUEUE_INFO_SET(queue_info->udp_dp_en, UDP_DP_EN) |

ERROR:CODE_INDENT: code indent should use tabs where possible
#671: FILE: drivers/net/hinic3/hinic3_tx.c:856:
+^I^I^I    ^I^ISQ_CTRL_COMPACT_QUEUE_INFO_SET(queue_info->udp_dp_en, UDP_DP_EN) |$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#671: FILE: drivers/net/hinic3/hinic3_tx.c:856:
+^I^I^I    ^I^ISQ_CTRL_COMPACT_QUEUE_INFO_SET(queue_info->udp_dp_en, UDP_DP_EN) |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#672: FILE: drivers/net/hinic3/hinic3_tx.c:857:
+^I^I^I    ^I^ISQ_CTRL_COMPACT_QUEUE_INFO_SET(queue_info->ufo, UFO) |$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#672: FILE: drivers/net/hinic3/hinic3_tx.c:857:
+^I^I^I    ^I^ISQ_CTRL_COMPACT_QUEUE_INFO_SET(queue_info->ufo, UFO) |$

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#673: FILE: drivers/net/hinic3/hinic3_tx.c:858:
+			    		SQ_CTRL_COMPACT_QUEUE_INFO_SET(queue_info->pkt_type, PKT_TYPE);

ERROR:CODE_INDENT: code indent should use tabs where possible
#673: FILE: drivers/net/hinic3/hinic3_tx.c:858:
+^I^I^I    ^I^ISQ_CTRL_COMPACT_QUEUE_INFO_SET(queue_info->pkt_type, PKT_TYPE);$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#673: FILE: drivers/net/hinic3/hinic3_tx.c:858:
+^I^I^I    ^I^ISQ_CTRL_COMPACT_QUEUE_INFO_SET(queue_info->pkt_type, PKT_TYPE);$

WARNING:TYPO_SPELLING: 'extented' may be misspelled - perhaps 'extended'?
#732: FILE: drivers/net/hinic3/hinic3_tx.c:918:
+				 * 2. SGE number > 1: wqe is handlerd as extented wqe by nic.
 				                                         ^^^^^^^^

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#734: FILE: drivers/net/hinic3/hinic3_tx.c:920:
+				if (mbuf_pkt->ol_flags & HINIC3_PKT_TX_TCP_SEG || wqe_info.wqebb_cnt > 1)

CHECK:BRACES: Unbalanced braces around else statement
#736: FILE: drivers/net/hinic3/hinic3_tx.c:922:
+			} else

WARNING:TYPO_SPELLING: 'warpped' may be misspelled - perhaps 'wrapped'?
#756: FILE: drivers/net/hinic3/hinic3_tx.c:938:
+		/* Task or bd section maybe warpped for one wqe. */
 		                            ^^^^^^^

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#766: FILE: drivers/net/hinic3/hinic3_tx.c:943:
+											&wqe_combo, &wqe_info);

ERROR:CODE_INDENT: code indent should use tabs where possible
#797: FILE: drivers/net/hinic3/hinic3_tx.c:1024:
+^I^I^I    ^I^I^I^I free_wqebbs,$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#797: FILE: drivers/net/hinic3/hinic3_tx.c:1024:
+^I^I^I    ^I^I^I^I free_wqebbs,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#798: FILE: drivers/net/hinic3/hinic3_tx.c:1025:
+^I^I^I    ^I^I^I^I txq->q_depth);$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#798: FILE: drivers/net/hinic3/hinic3_tx.c:1025:
+^I^I^I    ^I^I^I^I txq->q_depth);$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#959: FILE: drivers/net/hinic3/hinic3_tx.h:289:
+#define SQ_TASK_INFO_PKT_1588_MASK ^I^I^I0x1U$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#960: FILE: drivers/net/hinic3/hinic3_tx.h:290:
+#define SQ_TASK_INFO_IPSEC_PROTO_MASK ^I^I0x1U$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#961: FILE: drivers/net/hinic3/hinic3_tx.h:291:
+#define SQ_TASK_INFO_OUT_L3_EN_MASK ^I^I0x1U$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#962: FILE: drivers/net/hinic3/hinic3_tx.h:292:
+#define SQ_TASK_INFO_OUT_L4_EN_MASK ^I^I0x1U$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#963: FILE: drivers/net/hinic3/hinic3_tx.h:293:
+#define SQ_TASK_INFO_INNER_L3_EN_MASK ^I^I0x1U$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#964: FILE: drivers/net/hinic3/hinic3_tx.h:294:
+#define SQ_TASK_INFO_INNER_L4_EN_MASK ^I^I0x1U$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#965: FILE: drivers/net/hinic3/hinic3_tx.h:295:
+#define SQ_TASK_INFO_ESP_NEXT_PROTO_MASK ^I0x3U$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#966: FILE: drivers/net/hinic3/hinic3_tx.h:296:
+#define SQ_TASK_INFO_VLAN_VALID_MASK ^I^I0x1U$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#967: FILE: drivers/net/hinic3/hinic3_tx.h:297:
+#define SQ_TASK_INFO_VLAN_SEL_MASK ^I^I^I0x7U$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#968: FILE: drivers/net/hinic3/hinic3_tx.h:298:
+#define SQ_TASK_INFO_VLAN_TAG_MASK ^I^I^I0xFFFFU$

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#1004: FILE: drivers/net/hinic3/hinic3_tx.h:402:
+									   struct hinic3_sq_wqe_combo *wqe_combo);

WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#1015: FILE: drivers/net/hinic3/hinic3_tx.h:413:
+										struct hinic3_sq_wqe_combo *wqe_combo);

total: 10 errors, 30 warnings, 1 checks, 904 lines checked

Previous message (by thread): |WARNING| pw160661 [PATCH 7/7] net/hinic3: use different callback func to support htn fdir
Next message (by thread): |WARNING| pw160657 [PATCH 5/7] net/hinic3: add rx ops to support Compact CQE
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the test-report mailing list