|WARNING| pw160659 [PATCH 4/7] net/hinic3: add fun init ops to support Compact CQE

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/160659

_coding style issues_


WARNING:BAD_SIGN_OFF: Do not use whitespace before Signed-off-by:
#67: 
 Signed-off-by: Feifei Wang <wangfeifei40 at huawei.com>

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#92: FILE: drivers/net/hinic3/hinic3_ethdev.c:434:
+	struct hinic3_nic_dev *nic_dev = (struct hinic3_nic_dev*)hwdev->dev_handle;

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#144: FILE: drivers/net/hinic3/hinic3_ethdev.c:674:
+static void
+hinic3_dev_tnl_tso_support(struct rte_eth_dev_info *info, struct hinic3_nic_dev *nic_dev) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#146: FILE: drivers/net/hinic3/hinic3_ethdev.c:676:
+	if (HINIC3_SUPPORT_GENEVE_OFFLOAD(nic_dev)) {
+		info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#149: FILE: drivers/net/hinic3/hinic3_ethdev.c:679:
+	if (HINIC3_SUPPORT_IPXIP_OFFLOAD(nic_dev)) {
+		info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO;
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc != nic_dev->rxqs[0]->q_depth'
#183: FILE: drivers/net/hinic3/hinic3_ethdev.c:981:
+	if (qid != 0 && (nb_desc != nic_dev->rxqs[0]->q_depth)) {

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#225: FILE: drivers/net/hinic3/hinic3_ethdev.c:1061:
+	if (HINIC3_SUPPORT_RX_HW_COMPACT_CQE(nic_dev)) {
+

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#268: FILE: drivers/net/hinic3/hinic3_ethdev.c:1127:
+			PMD_DRV_LOG(ERR, "Allocate ci mem zone failed, dev_name: %s", dev->data->name);

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#280: FILE: drivers/net/hinic3/hinic3_ethdev.c:1139:
+										rq_depth * sizeof(*rxq->rx_cqe),

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#281: FILE: drivers/net/hinic3/hinic3_ethdev.c:1140:
+										RTE_CACHE_LINE_SIZE, socket_id);

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#625: FILE: drivers/net/hinic3/hinic3_ethdev.h:105:
+typedef void  (*nic_rx_get_cqe_info_t)(struct hinic3_rxq *rx_queue, volatile struct hinic3_rq_cqe *rx_cqe,

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#626: FILE: drivers/net/hinic3/hinic3_ethdev.h:106:
+									   struct hinic3_cqe_info *cqe_info);

WARNING:TYPO_SPELLING: 'funcion' may be misspelled - perhaps 'function'?
#628: FILE: drivers/net/hinic3/hinic3_ethdev.h:108:
+/* Rx CQE check status callback funcion */
                                 ^^^^^^^

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1123: FILE: drivers/net/hinic3/hinic3_nic_io.c:414:
+		cmd = nic_dev->cmdq_ops->prepare_cmd_buf_qp_context_multi_store(

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#1124: FILE: drivers/net/hinic3/hinic3_nic_io.c:415:
+											nic_dev, cmd_buf,

WARNING:LONG_LINE: line length of 129 exceeds 100 columns
#1125: FILE: drivers/net/hinic3/hinic3_nic_io.c:416:
+											HINIC3_QP_CTXT_TYPE_SQ, q_id, max_ctxts);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1130: FILE: drivers/net/hinic3/hinic3_nic_io.c:419:
+									  cmd, cmd_buf, &out_param, 0);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 16)
#1157: FILE: drivers/net/hinic3/hinic3_nic_io.c:463:
+while (q_id < nic_dev->num_rqs) {
 		max_ctxts = (nic_dev->num_rqs - q_id) > HINIC3_Q_CTXT_MAX

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1173: FILE: drivers/net/hinic3/hinic3_nic_io.c:467:
+		cmd = nic_dev->cmdq_ops->prepare_cmd_buf_qp_context_multi_store(

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#1174: FILE: drivers/net/hinic3/hinic3_nic_io.c:468:
+											nic_dev, cmd_buf,

WARNING:LONG_LINE: line length of 129 exceeds 100 columns
#1175: FILE: drivers/net/hinic3/hinic3_nic_io.c:469:
+											HINIC3_QP_CTXT_TYPE_RQ, q_id, max_ctxts);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1180: FILE: drivers/net/hinic3/hinic3_nic_io.c:472:
+									  cmd, cmd_buf, &out_param, 0);

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1228: FILE: drivers/net/hinic3/hinic3_nic_io.c:562:
+#define HINIC3_RX_CQE_TIMER_LOOP ^I^I15$

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1248: FILE: drivers/net/hinic3/hinic3_nic_io.c:582:
+	if (hinic3_get_driver_feature(nic_dev) & NIC_F_HTN_CMDQ)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#1250: FILE: drivers/net/hinic3/hinic3_nic_io.c:584:
+	else {

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#1278: FILE: drivers/net/hinic3/hinic3_nic_io.c:612:
+							  qid: %d, err: %d, status: 0x%x, out_size: 0x%x",

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1279: FILE: drivers/net/hinic3/hinic3_nic_io.c:613:
+							  q_id, err, cqe_ctx.msg_head.status, out_size);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#1329: FILE: drivers/net/hinic3/hinic3_nic_io.c:719:
+								 &msg, sizeof(msg), &msg, &out_size);

total: 2 errors, 21 warnings, 5 checks, 1252 lines checked