|WARNING| pw160660 [PATCH 3/7] net/hinic3: use different callback func to split new/old cmdq operations

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/160660

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#103: FILE: drivers/net/hinic3/base/hinic3_nic_cfg.c:443:
+	struct hinic3_nic_dev *nic_dev = (struct hinic3_nic_dev*)hwdev->dev_handle;

ERROR:SPACING: space required after that ',' (ctx:VxV)
#152: FILE: drivers/net/hinic3/base/hinic3_nic_cfg.c:1189:
+	nic_dev->cmdq_ops->cmd_buf_to_rss_indir_table(cmd_buf,indir_table);
 	                                                     ^

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#443: FILE: drivers/net/hinic3/hinic3_nic_io.h:29:
+#define HINIC3_Q_CTXT_MAX	((uint16_t)(((HINIC3_CMDQ_BUF_SIZE - 8) - RTE_PKTMBUF_HEADROOM) / 64))

WARNING:LONG_LINE: line length of 117 exceeds 100 columns
#446: FILE: drivers/net/hinic3/hinic3_nic_io.h:32:
+									+ (num_sqs) * sizeof(struct hinic3_sq_ctxt)))

WARNING:LONG_LINE: line length of 117 exceeds 100 columns
#448: FILE: drivers/net/hinic3/hinic3_nic_io.h:34:
+									+ (num_rqs) * sizeof(struct hinic3_rq_ctxt)))

WARNING:LONG_LINE: line length of 138 exceeds 100 columns
#459: FILE: drivers/net/hinic3/hinic3_nic_io.h:50:
+													   struct hinic3_cmd_buf *cmd_buf,

WARNING:LONG_LINE: line length of 143 exceeds 100 columns
#460: FILE: drivers/net/hinic3/hinic3_nic_io.h:51:
+													   enum hinic3_qp_ctxt_type ctxt_type);

WARNING:LONG_LINE: line length of 146 exceeds 100 columns
#463: FILE: drivers/net/hinic3/hinic3_nic_io.h:54:
+														   struct hinic3_cmd_buf *cmd_buf,

WARNING:LONG_LINE: line length of 150 exceeds 100 columns
#464: FILE: drivers/net/hinic3/hinic3_nic_io.h:55:
+														   enum hinic3_qp_ctxt_type ctxt_type,

WARNING:LONG_LINE: line length of 155 exceeds 100 columns
#465: FILE: drivers/net/hinic3/hinic3_nic_io.h:56:
+														   uint16_t start_qid, uint16_t max_ctxts);

WARNING:LONG_LINE: line length of 152 exceeds 100 columns
#468: FILE: drivers/net/hinic3/hinic3_nic_io.h:59:
+												   uint16_t vlan_tag, uint16_t q_id, uint8_t vlan_mode);

WARNING:LONG_LINE: line length of 142 exceeds 100 columns
#471: FILE: drivers/net/hinic3/hinic3_nic_io.h:62:
+														  const uint32_t *indir_table,

WARNING:LONG_LINE: line length of 146 exceeds 100 columns
#472: FILE: drivers/net/hinic3/hinic3_nic_io.h:63:
+														  struct hinic3_cmd_buf *cmd_buf);

WARNING:LONG_LINE: line length of 146 exceeds 100 columns
#475: FILE: drivers/net/hinic3/hinic3_nic_io.h:66:
+														  struct hinic3_cmd_buf *cmd_buf);

WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#477: FILE: drivers/net/hinic3/hinic3_nic_io.h:68:
+typedef void     (*cmd_buf_to_rss_indir_table_t)(const struct hinic3_cmd_buf *cmd_buf, uint32_t *indir_table);

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#682: FILE: drivers/net/hinic3/htn_adapt/hinic3_htn_cmdq.c:76:
+				       uint16_t func_id, uint16_t vlan_tag, uint16_t q_id, uint8_t vlan_mode)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#713: FILE: drivers/net/hinic3/htn_adapt/hinic3_htn_cmdq.c:107:
+	for (i = 0; i < HINIC3_RSS_INDIR_SIZE; i++) {
+		indir_tbl[i] = (uint8_t)(*(indir_table + i));
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#752: FILE: drivers/net/hinic3/htn_adapt/hinic3_htn_cmdq.c:146:
+	for (i = 0; i < HINIC3_RSS_INDIR_SIZE; i++) {
+		indir_table[i] = *(indir_tbl + i);
+	}

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#922: FILE: drivers/net/hinic3/stn_adapt/hinic3_stn_cmdq.c:73:
+				       uint16_t func_id, uint16_t vlan_tag, uint16_t q_id, uint8_t vlan_mode)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#952: FILE: drivers/net/hinic3/stn_adapt/hinic3_stn_cmdq.c:103:
+	for (i = 0; i < HINIC3_RSS_INDIR_SIZE; i++) {
+		indir_tbl->entry[i] = (uint16_t)(*(indir_table + i));
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#979: FILE: drivers/net/hinic3/stn_adapt/hinic3_stn_cmdq.c:130:
+	for (i = 0; i < HINIC3_RSS_INDIR_SIZE; i++) {
+		indir_table[i] = *(indir_tbl + i);
+	}

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#990: FILE: drivers/net/hinic3/stn_adapt/hinic3_stn_cmdq.c:141:
+^I^I.prepare_cmd_buf_set_rss_indir_table = ^I  prepare_cmd_buf_set_rss_indir_table,$

total: 2 errors, 20 warnings, 0 checks, 886 lines checked