|WARNING| app/testpmd: fix multi-pool Rx setup with --no-NUMA

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166487

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-02

# DPDK Patch Review

## Patch Summary
This patch fixes multi-pool Rx queue setup in testpmd when NUMA is disabled (`--no-NUMA`). The fix centralizes NUMA socket remapping in `mbuf_pool_find()` and removes duplicate remapping from `start_port()`.

---

## Review Findings

### Errors

None found.

### Warnings

**W1: Release notes missing**

This patch fixes a bug that prevents testpmd from setting up Rx queues with multiple segment sizes when NUMA is disabled (e.g., `--mbuf-size=314,978 --rxpkts=186,978` fails). This is a user-visible behavioral fix that should be documented.

**Suggested fix:**
Add an entry to `doc/guides/rel_notes/release_26_07.rst` under "Fixed Issues":

```rst
* **app/testpmd: Fixed multi-pool Rx setup with --no-NUMA.**

  Fixed Rx queue setup failure when NUMA is disabled and multiple segment
  sizes are configured (e.g., ``--mbuf-size=314,978 --rxpkts=186,978``).
  Per-segment pool lookup now correctly uses ``SOCKET_ID_ANY`` when NUMA
  support is disabled.
```

---

### Info

**I1: Code quality improvement**

The centralization of NUMA socket remapping in `mbuf_pool_find()` is good design. It eliminates the duplicate conditional in `start_port()` and ensures all callers of `mbuf_pool_find()` consistently handle the NUMA-disabled case. The fix is minimal and focused.

**I2: Correctness of the fix**

The patch correctly identifies that when `numa_support` is false, all mbuf pools are created with `SOCKET_ID_ANY`, so lookups must also use `SOCKET_ID_ANY`. The fix ensures `mbuf_pool_find()` matches the allocation behavior in `mbuf_pool_create()` (which already checks `numa_support`).

---

## Compliance Summary

- **Correctness**:  No bugs identified
- **Style**:  Compliant
- **API**:  No API changes
- **Documentation**:   Release notes should be added
- **Testing**:  Fix is testable with `--no-NUMA --mbuf-size=314,978 --rxpkts=186,978`

---

## Recommendation

**Accept with minor documentation addition.** Add the suggested release notes entry for the current release (26.07 based on the patch date). The code change is correct and improves maintainability.