|WARNING| app/testpmd: fix multi-pool Rx setup with --no-NUMA

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166487

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-02

# DPDK Patch Review

## Summary
This patch fixes a multi-pool Rx setup failure when testpmd runs with `--no-NUMA`. The fix is correct and follows DPDK guidelines.

## Review Findings

### Errors
None.

### Warnings
None.

### Info

**Style observation - unnecessary cast:**
Line testpmd.h:895 contains an unnecessary explicit cast to `unsigned int` for `SOCKET_ID_ANY`:
```c
sock_id = (unsigned int)SOCKET_ID_ANY;
```

`SOCKET_ID_ANY` is already defined as `((unsigned int)-1)` in `rte_eal.h`, so the cast is redundant. However, this is a minor style point and does not affect correctness. The existing code in the function also uses this cast pattern, so changing it would be inconsistent with the surrounding code style.

**Code correctness:**
The patch correctly addresses the root cause by moving the NUMA check into `mbuf_pool_find()` where socket_id is used for pool name construction, rather than trying to handle it at every call site. This ensures consistent behavior across all callers.

**Testing:**
The patch description provides a clear reproducer (`--mbuf-size=314,978 --rxpkts=186,978` with `--no-NUMA`), which is helpful for validation.

**Release notes:**
This is a bug fix targeting `stable at dpdk.org`. Bug fixes do not require release notes updates per the guidelines.

## Conclusion
**LGTM** - The patch is correct and ready for merge. The unnecessary cast is a pre-existing style in the codebase and does not need to block this fix.