|WARNING| test/bpf_validate: use unit_test_suite_runner

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166545

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-04

# DPDK Patch Review

## Summary
This patch refactors BPF validation tests from individual test registrations to a single test suite using `unit_test_suite_runner`. The change is structurally sound and follows DPDK test framework patterns.

## Findings

### Errors
None found.

### Warnings

**Missing blank line before suite definition**

The static structure `test_bpf_validate_suite` should be separated from the preceding function `test_mem_ldx_dw_heap()` by a blank line for consistency with DPDK formatting conventions.

```c
/* Current */
	});
}

static struct
unit_test_suite test_bpf_validate_suite  = {

/* Suggested */
	});
}

static struct
unit_test_suite test_bpf_validate_suite  = {
```

**Extra space in structure name line**

```c
/* Line 2186 - double space before '=' */
unit_test_suite test_bpf_validate_suite  = {

/* Should be */
unit_test_suite test_bpf_validate_suite = {
```

### Info

**Suite name clarity**

The suite name "Test BPF Validate Unit Test Suite" is somewhat redundant ("Test" appears twice). Consider:

```c
.suite_name = "BPF Validate Test Suite",
```

This is a minor style preference; the current name is acceptable.

---

## Positive Observations

- Correctly uses `unit_test_suite_runner` infrastructure as recommended in AGENTS.md
- Properly uses `TEST_CASE()` macros for all test functions
- Correctly registers with `REGISTER_FAST_TEST` using appropriate flags (`NOHUGE_OK`, `ASAN_OK`)
- `TEST_CASES_END()` sentinel properly placed
- All test functions return `int` and use `TEST_SUCCESS` as required
- No release notes needed (test-only change per guidelines)
- Removes obsolete `REGISTER_ATTIC_TEST` calls, consolidating to a single registration point