|WARNING| test/bpf_validate: use unit_test_suite_runner

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166545

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-04

# DPDK Patch Review

## Summary
This patch converts BPF validation tests from individual `REGISTER_ATTIC_TEST` entries to a single test using `unit_test_suite_runner`. The conversion is mechanically correct and follows DPDK test infrastructure guidelines.

---

## Findings

### Errors
None.

### Warnings
None.

### Info

**Test organization improvement**
The conversion from 29 individual `REGISTER_ATTIC_TEST` entries to a single `unit_test_suite_runner`-based test is the correct approach per AGENTS.md guidelines. The functional test infrastructure section explicitly recommends this pattern. The test functions themselves are unchanged, only the registration mechanism was updated.

**Code quality observations (no action required)**
- All test functions already return `TEST_SUCCESS` on success and use `TEST_ASSERT` macros for validation (verified by reviewing existing test functions like `test_alu64_div_mod_big_constant`, `test_alu64_div_mod_big_range`, etc.)
- The suite uses `REGISTER_FAST_TEST` with appropriate `NOHUGE_OK` and `ASAN_OK` flags, which is the current correct format per the guidelines
- The test suite name "Test BPF Validate Unit Test Suite" is descriptive and follows naming conventions

---

## Conclusion

This patch is **ready for integration**. It correctly migrates BPF validation tests to the recommended `unit_test_suite_runner` infrastructure without introducing any correctness, style, or process violations. The mechanical conversion is complete and follows all applicable guidelines.