|WARNING| [2/2] net/ixgbe: fix return value of close operation
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Jul 10 16:10:03 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166677
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-10
# DPDK Patch Review
## Patch 1/2: net/i40e: fix return value of close operation
### Errors
None found.
### Warnings
None found.
### Info
**Correctness:** The fix is correct. `rte_intr_callback_unregister()` returns a positive count of unregistered callbacks on success, but the `i40e_dev_close()` function's callers expect 0 for success and negative for error. Without this fix, a successful unregister (returning 1) would be misinterpreted as a failure by applications checking `rte_eth_dev_close() != 0`.
**Pattern:** This is a standard error code normalization pattern. The retry loop already handles `-ENOENT` (no callbacks registered) as a success case; normalizing the positive return value to 0 completes the fix.
## Patch 2/2: net/ixgbe: fix return value of close operation
### Errors
None found.
### Warnings
None found.
### Info
**Correctness:** Identical issue and fix as patch 1/2, applied to the ixgbe driver. The fix is correct for the same reasons.
---
## Summary
Both patches correctly address the same bug pattern in two different Intel drivers (i40e and ixgbe). The fixes are minimal, targeted, and appropriate for backporting to stable branches (as indicated by the `Cc: stable at dpdk.org` tag).
**No issues found.** The patches are ready for merge.
More information about the test-report
mailing list