|WARNING| [2/2] net/ixgbe: fix return value of close operation

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166677

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-10

# DPDK Patch Review

## Patch 1/2: net/i40e: fix return value of close operation

### Errors

None identified.

### Warnings

None identified.

### Info

**Patch overview**: This patch fixes a bug where `i40e_dev_close()` incorrectly returns a positive value (the count of unregistered callbacks) instead of 0 on success, causing applications to misinterpret successful close operations as failures.

**Code correctness**: The fix is correct. `rte_intr_callback_unregister()` returns the number of callbacks unregistered (positive) on success, or negative error codes on failure. The conditional `if (ret >= 0 || ret == -ENOENT)` correctly identifies success cases, and setting `ret = 0` before `break` ensures the function returns 0 to the caller as expected.

**Style compliance**: The added line follows DPDK style (tab indentation, proper placement).

**No release notes needed**: This is a bug fix in driver code. Driver-specific fixes do not require release notes unless they affect public API behavior. The fix corrects an internal return value handling issue.

---

## Patch 2/2: net/ixgbe: fix return value of close operation

### Errors

None identified.

### Warnings

None identified.

### Info

**Patch overview**: This patch fixes the same bug as patch 1/2, but in the ixgbe driver. The issue and fix are identical: `ixgbe_dev_close()` was leaking a positive return value from `rte_intr_callback_unregister()`, causing applications to misinterpret success as failure.

**Code correctness**: The fix is correct for the same reasons as patch 1/2.

**Style compliance**: The added line follows DPDK style.

**No release notes needed**: Same reasoning as patch 1/2.

---

## Summary

Both patches correctly fix a bug where driver close operations returned positive values (callback unregister counts) instead of 0 on success. The fixes are minimal, correct, and follow DPDK coding style. No issues found.

**Note**: These patches are clean bug fixes with no style, correctness, or process violations.