|WARNING| [2/2] net/ixgbe: fix return value of close operation

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166677

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-10

# DPDK Patch Review

## Patch 1/2: net/i40e: fix return value of close operation

### Errors

None.

### Warnings

None.

### Info

**Correctness**: The fix is correct. `rte_intr_callback_unregister()` returns the number of callbacks unregistered (a positive integer) on success, and the code was leaking this positive value as the return from `i40e_dev_close()`. Setting `ret = 0` on the success path ensures applications checking `rte_eth_dev_close() != 0` see success as intended.

**Pattern consistency**: The same bug likely exists in other drivers that call `rte_intr_callback_unregister()` and return `ret` without normalizing it to 0 on success. Consider auditing similar patterns across the codebase.

---

## Patch 2/2: net/ixgbe: fix return value of close operation

### Errors

None.

### Warnings

None.

### Info

**Correctness**: The fix is correct for the same reason as patch 1/2. The pattern and logic are identical to the i40e fix.

---

## Overall Assessment

Both patches correctly fix a logic error where a positive success return value from `rte_intr_callback_unregister()` was incorrectly propagated as the return value of the device close operation, causing applications to interpret success as failure.

The fixes are minimal, targeted, and follow the existing error-handling pattern in the code (checking `ret >= 0 || ret == -ENOENT` for success). The `Fixes:` tags and `Cc: stable at dpdk.org` are appropriate.

No style, API, or documentation issues identified. The patches are ready for merge.