|WARNING| [v2] version: 26.11.0-rc0

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166874

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-23

# DPDK Patch Review

## Summary
This patch starts a new release cycle (26.11.0-rc0) by bumping version numbers and temporarily updating symbol versioning for ethdev and net/mlx5. The commit message indicates this is temporary and will be removed in subsequent commits.

---

## Errors

None identified.

---

## Warnings

### 1. Symbol versioning temporary bump unclear in code comments
**File:** `drivers/net/mlx5/mlx5_driver_event.c`, `drivers/net/mlx5/mlx5_flow.c`, `lib/ethdev/rte_flow.c`

The commit message states "Note: we need to bump the version for symbol compat in ethdev and net/mlx5 temporarily. Next commits will drop this compat entirely."

However, there are no code comments at the changed lines indicating this is temporary or why it exists. Future reviewers or maintainers examining these files in isolation won't know these version bumps are placeholders.

**Suggested fix:**
Add a comment above each `RTE_DEFAULT_SYMBOL` change:
```c
/* TODO: temporary version bump, will be removed when dropping compat */
RTE_DEFAULT_SYMBOL(27, int, rte_pmd_mlx5_driver_event_cb_register,
```

---

### 2. CI ABI checks disabled without documenting re-enablement
**File:** `.github/workflows/build.yml`

The patch changes `checks: abi+debug+doc+examples+tests` to `checks: debug+doc+examples+tests`, disabling ABI checks. The commit message explains this is because "compatibility is not preserved" for a new major release.

However, there's no issue/TODO tracking when ABI checks should be re-enabled. ABI checks are typically re-enabled after the first RC to catch regressions within the release cycle. Leaving them disabled indefinitely is not standard practice.

**Suggested action:**
Document in the commit message or with a TODO comment when ABI checks should be restored (typically after RC1 or when the reference version is established).

---

### 3. Release notes file follows template
**File:** `doc/guides/rel_notes/release_26_11.rst`

The new release notes file is entirely boilerplate template content with no actual content yet. This is expected at the start of a release cycle, but the patch description doesn't mention that contributors should begin filling this in.

Not a code issue, but worth noting: the "New Features", "Removed Items", "API Changes", "ABI Changes", "Known Issues", and "Tested Platforms" sections are all empty templates.

---

## Info

### 1. Consistent pattern with previous release cycles
The changes to `ABI_VERSION`, `VERSION`, `devtools/libabigail.abignore`, and CI workflow follow the established pattern from previous DPDK release cycle transitions. The approach is consistent with DPDK project practices.

---

## Process Compliance

-  Release notes added for new release cycle
-  ABI version bumped for new major release
-  CI configuration updated to disable ABI checks (appropriate for major release start)
-  Version file updated correctly
-  ABI exceptions cleared (appropriate for new major version)
-  Patch follows DPDK versioning scheme

The patch appears to follow DPDK release management practices. The temporary symbol version bumps are unusual but explained in the commit message as an intermediate state that will be cleaned up in follow-on patches.