|WARNING| [v2] version: 26.11.0-rc0

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166874

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-23

# DPDK Patch Review - series.patch

## Summary
This patch bumps DPDK version to 26.11.0-rc0 and updates ABI version to 27.0, creating new release notes and dropping ABI compatibility checks for the new release cycle. The patch also includes temporary symbol version bumps for ethdev and mlx5 driver functions.

---

## Errors

None found. This is a version bump patch with administrative changes. The symbol version updates are mechanical and match the new ABI version.

---

## Warnings

**1. Temporary symbol version bumps should be accompanied by cleanup plan**

The commit message states "we need to bump the version for symbol compat in ethdev and net/mlx5 temporarily. Next commits will drop this compat entirely." However, the release notes file does not document this temporary state or the planned removal of the compat symbols.

**Suggested action:** Add a note in the release notes `API Changes` or `ABI Changes` section mentioning:
- Which symbols still have version compatibility
- That these will be removed in subsequent patches of this series
- Or document the removal in the release notes if the removal happens in later patches

**Location:** `doc/guides/rel_notes/release_26_11.rst`

---

**2. Symbol version comments in code would improve clarity**

The modified symbol version macros (`RTE_DEFAULT_SYMBOL(27, ...)`) in `drivers/net/mlx5/` and `lib/ethdev/` lack inline comments explaining why version 27 symbols exist when the code is marked for removal.

**Suggested action:** Add inline comments near the modified macros:
```c
/* Temporary compat symbol - will be removed after full migration */
RTE_DEFAULT_SYMBOL(27, int, rte_pmd_mlx5_driver_event_cb_register, ...)
```

This helps future maintainers understand the temporary nature of these changes.

**Locations:**
- `drivers/net/mlx5/mlx5_driver_event.c:239, 272`
- `drivers/net/mlx5/mlx5_flow.c:12540, 12569`
- `lib/ethdev/rte_flow.c:285`

---

## Info

**1. Consider documenting the version bump rationale**

The release notes file is created but contains only template comments. For a major release cycle start (new ABI version), it may be helpful to add a brief note about:
- Why ABI compatibility is broken (new major release)
- What the ABI version bump means for downstream users
- Reference to the DPDK ABI policy

This is optional but improves clarity for users scanning release notes.

---

**2. CI configuration change disables ABI checks**

The workflow change from `checks: abi+debug+doc+examples+tests` to `checks: debug+doc+examples+tests` and `REF_GIT_TAG: none` correctly disables ABI compatibility checking for the new release cycle. This is appropriate but should be re-enabled once the release stabilizes and the compat symbols are fully removed.

**File:** `.github/workflows/build.yml:15,99`

---

## Overall Assessment

This patch correctly implements a version bump for a new DPDK release cycle. The mechanical changes (ABI version, symbol versions, CI configuration) are appropriate. The main improvement would be better documentation of the temporary symbol compat state and the planned cleanup, both in the release notes and in code comments.