|WARNING| lpm6, fib6, rib6, table: remove deprecated functions and macros

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166928

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-24

# DPDK Patch Review

## Summary

This patch removes deprecated IPv6-related functions and macros from lpm6, fib6, rib6, and table libraries. The deprecation was announced in DPDK 24.11, and this patch removes them in 26.11 (2 releases later, which is appropriate for the deprecation policy).

## Errors

None found.

## Warnings

**Missing ABI section in release notes** (Warning):
The patch removes public API symbols, which is an ABI change.
The release notes should include an "ABI Changes" section documenting the removed symbols,
not just list them under "Removed Items".

Suggested addition to `doc/guides/rel_notes/release_26_11.rst`:

```rst
ABI Changes
-----------

* **lpm, fib, rib, table: Removed deprecated IPv6 API.**

  The following deprecated macros and functions were removed:
  
  - ``RTE_FIB6_IPV6_ADDR_SIZE``, ``RTE_FIB6_MAXDEPTH``
  - ``RTE_LPM6_IPV6_ADDR_SIZE``, ``RTE_LPM6_MAX_DEPTH``
  - ``RTE_LPM_IPV6_ADDR_SIZE``
  - ``RTE_RIB6_IPV6_ADDR_SIZE``
  - ``rte_rib6_copy_addr()``, ``rte_rib6_is_equal()``, ``get_msk_part()``
```

**Inconsistent naming in release notes** (Info):
The removed items list uses bare function names (`get_msk_part`)
but does not include the `rte_` prefix consistently.
For clarity, function names should include parentheses to distinguish them from macros:
`get_msk_part()` instead of `get_msk_part`.

## Positive Observations

1. **Correct deprecation timeline**: The functions were deprecated in 24.11 and are being removed in 26.11, which follows the standard 2-release deprecation period.

2. **Clean removal**: All deprecated items are removed completely with no stray references left behind.

3. **Proper release notes**: The patch includes release notes documenting the removal.

4. **No correctness issues**: The removed code is inline functions and macros that are no longer exported; no resource leaks or functional bugs introduced.

## Overall Assessment

The patch is functionally correct and follows proper deprecation procedures. The only actionable item is to add an "ABI Changes" section to the release notes to properly document this as an ABI-breaking change.