|WARNING| lpm6, fib6, rib6, table: remove deprecated functions and macros

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166928

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-24

# DPDK Patch Review

## Summary
This patch removes deprecated IPv6 address handling functions and macros from lpm6, fib6, rib6, and table libraries. The deprecation was announced in DPDK 24.11, making this a valid removal for the 26.11 release.

## Findings

### Errors

None found. The patch correctly removes deprecated API as documented.

### Warnings

**1. Release notes should document replacement API**

The release notes list the removed symbols but do not indicate what applications should use instead. Add guidance for each removed item:

```rst
* Deprecated functions removed:

  - ``RTE_FIB6_IPV6_ADDR_SIZE`` - use ``RTE_IPV6_ADDR_SIZE``
  - ``RTE_FIB6_MAXDEPTH`` - use ``RTE_IPV6_MAX_DEPTH``
  - ``RTE_LPM6_IPV6_ADDR_SIZE`` - use ``RTE_IPV6_ADDR_SIZE``
  - ``RTE_LPM6_MAX_DEPTH`` - use ``RTE_IPV6_MAX_DEPTH``
  - ``RTE_LPM_IPV6_ADDR_SIZE`` - use ``RTE_IPV6_ADDR_SIZE``
  - ``RTE_RIB6_IPV6_ADDR_SIZE`` - use ``RTE_IPV6_ADDR_SIZE``
  - ``get_msk_part`` - no direct replacement (internal helper)
  - ``rte_rib6_copy_addr`` - use direct struct assignment or ``rte_memcpy()``
  - ``rte_rib6_is_equal`` - use ``rte_ipv6_addr_eq()``
```

The deprecation messages in the removed code already point to replacements (`rte_ipv6_addr_eq`, direct struct assignment), so this information is available but should be captured in the release notes for users upgrading.

**2. Verify no remaining usages in DPDK codebase**

Before removing these functions, ensure no internal DPDK code (drivers, examples, tests) still uses them. The patch should have been preceded by cleanup patches converting all internal usage to the replacement API. This cannot be verified from the patch alone but should be confirmed with `git grep` across the tree.

### Info

None.

---

## Overall Assessment

The patch is technically correct for removing deprecated API at the appropriate release boundary (two releases after deprecation: 24.11 - 26.11). The only improvement needed is enhancing the release notes to document replacement API for each removed symbol, helping users migrate their applications.