|WARNING| pw162468 [RFC PATCH v1 02/21] net/intel/common: add flow engines infrastructure

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/162468

_coding style issues_


WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#221: FILE: drivers/net/intel/common/flow_engine.h:104:
+ * - Add/remove the flow rule to/from hardware or driver's internal state (flow_install/flow_uninstall)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'engine->ops->flow_alloc == NULL'
#484: FILE: drivers/net/intel/common/flow_engine.h:367:
+	if ((engine->ops->flow_alloc == NULL) != (engine->ops->flow_free == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'engine->ops->flow_free == NULL'
#484: FILE: drivers/net/intel/common/flow_engine.h:367:
+	if ((engine->ops->flow_alloc == NULL) != (engine->ops->flow_free == NULL))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#499: FILE: drivers/net/intel/common/flow_engine.h:382:
+	if (engine->ops->is_available != NULL) {
+		return engine->ops->is_available(engine, dev);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#855: FILE: drivers/net/intel/common/flow_engine.h:738:
+	if (engine->ops->flow_uninstall != NULL) {
+		return engine->ops->flow_uninstall(flow, error);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#911: FILE: drivers/net/intel/common/flow_engine.h:794:
+		if (ret == 0 && engine->ops->flow_install != NULL) {
+			ret = engine->ops->flow_install(flow, error);
+		}

total: 0 errors, 4 warnings, 2 checks, 1003 lines checked