|WARNING| pw162467 [RFC PATCH v1 01/21] ethdev: add flow graph API

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/162467

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following enum go on the same line
#143: FILE: lib/ethdev/rte_flow_graph.h:37:
+enum rte_flow_graph_node_expect
+{

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#146: FILE: lib/ethdev/rte_flow_graph.h:40:
+	RTE_FLOW_NODE_EXPECT_SPEC = (1 << 1),      /**< spec is required, mask and last must be NULL. */

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#147: FILE: lib/ethdev/rte_flow_graph.h:41:
+	RTE_FLOW_NODE_EXPECT_MASK = (1 << 2),      /**< mask is required, spec and last must be NULL. */

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#148: FILE: lib/ethdev/rte_flow_graph.h:42:
+	RTE_FLOW_NODE_EXPECT_SPEC_MASK = (1 << 3), /**< spec and mask required, last must be NULL. */

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#205: FILE: lib/ethdev/rte_flow_graph.h:99:
+	const enum rte_flow_graph_node_expect constraints; /**< Common validation constraints (ORed). */

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#207: FILE: lib/ethdev/rte_flow_graph.h:101:
+	rte_flow_node_process_fn process;    /**< Processing callback (NULL if no extraction needed). */

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#218: FILE: lib/ethdev/rte_flow_graph.h:112:
+	const size_t *next;  /**< Array of valid successor nodes, terminated by RTE_FLOW_EDGE_END. */

WARNING:LONG_LINE_COMMENT: line length of 131 exceeds 100 columns
#227: FILE: lib/ethdev/rte_flow_graph.h:121:
+	const enum rte_flow_item_type *ignore_nodes; /**< Additional node types to ignore, terminated by RTE_FLOW_ITEM_TYPE_END. */

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#294: FILE: lib/ethdev/rte_flow_graph.h:188:
+		if (!has_spec && __flow_graph_node_check_constraint(c, true, has_mask, has_last)) {
[...]
+		} else if (has_spec && __flow_graph_node_check_constraint(c, false, has_mask, has_last)) {
[...]

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#296: FILE: lib/ethdev/rte_flow_graph.h:190:
+		} else if (has_spec && __flow_graph_node_check_constraint(c, false, has_mask, has_last)) {

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#300: FILE: lib/ethdev/rte_flow_graph.h:194:
+		else if (!has_mask && __flow_graph_node_check_constraint(c, has_spec, true, has_last)) {

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#302: FILE: lib/ethdev/rte_flow_graph.h:196:
+		} else if (has_mask && __flow_graph_node_check_constraint(c, has_spec, false, has_last)) {

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#306: FILE: lib/ethdev/rte_flow_graph.h:200:
+		else if (!has_last && __flow_graph_node_check_constraint(c, has_spec, has_mask, true)) {

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#308: FILE: lib/ethdev/rte_flow_graph.h:202:
+		} else if (has_last && __flow_graph_node_check_constraint(c, has_spec, has_mask, false)) {

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#369: FILE: lib/ethdev/rte_flow_graph.h:263:
+__flow_graph_get_node_index(const struct rte_flow_graph *graph, const struct rte_flow_graph_node *node)

total: 1 errors, 14 warnings, 421 lines checked