|SUCCESS| power/amd_uncore: detect esmi lib64 using pkgconfig

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162785

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-03-31

Below is my review of the patch.

commit 20260331040958.126869-1-sivaprasad.tummala at amd.com
Author: Sivaprasad Tummala <sivaprasad.tummala at amd.com>
power/amd_uncore: detect esmi lib64 using pkgconfig

This patch replaces manual detection of e_smi_lib64 library from
find_library() with dependency() via pkg-config in meson.

> diff --git a/drivers/power/amd_uncore/meson.build b/drivers/power/amd_uncore/meson.build
> index cab260b64e..378eb72e50 100644
> --- a/drivers/power/amd_uncore/meson.build
> +++ b/drivers/power/amd_uncore/meson.build
> @@ -7,14 +7,12 @@ if not is_linux
>      subdir_done()
>  endif
>  
> -ESMI_header = '#include<e_smi/e_smi.h>'
> -lib = cc.find_library('e_smi64', required: false)
> -if not lib.found() or not cc.links(min_c_code, dependencies: lib)
> +dep = dependency('e_smi_lib64', required: false, method: 'pkg-config')
> +if not dep.found()
>      build = false
> -    reason = 'missing dependency, "libe_smi"'
> -else
> -    ext_deps += lib
> +    reason = 'missing dependency, "e_smi_lib64"'
> +    subdir_done()
>  endif
> -
>  sources = files('amd_uncore.c')
> +ext_deps += dep
>  deps += ['power']

Does this code still validate that the library contains the expected
symbols?  The original code used cc.links() with min_c_code to verify the
library could be linked, but the new dependency() approach removes this
check entirely.

Is the ESMI_header variable used elsewhere in the build system? If not,
removing it appears safe.  But if min_c_code or other code referenced it,
this could break the build.