|SUCCESS| [1/1] ml/cnxk: avoid overwriting layer name during load

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162791

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-03-31

git sha: 20260331085445.1105590-1-syalavarthi at marvell.com
Author: Srikanth Yalavarthi <syalavarthi at marvell.com>
Subject: [PATCH 1/1] ml/cnxk: avoid overwriting layer name during load

This patch removes code that copies the layer name from metadata during
the layer load process, since the layer name is already initialized
during metadata fetch and parsing.

> diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c
> index 628ff963c3c..77947120f25 100644
> --- a/drivers/ml/cnxk/cn10k_ml_ops.c
> +++ b/drivers/ml/cnxk/cn10k_ml_ops.c
> @@ -671,9 +671,6 @@ cn10k_ml_layer_load(void *device, uint16_t model_id, const char *layer_name, uin

[ ... ]

> -	/* Set layer name */
> -	rte_memcpy(layer->name, layer->glow.metadata.model.name, MRVL_ML_MODEL_NAME_LEN);
> -

Can this removal cause issues if layer->name is not properly initialized
before cn10k_ml_layer_load() is called?  Does every code path that leads
to cn10k_ml_layer_load() guarantee that layer->name is already
initialized from the metadata?

If layer->name is not initialized and the removed code was the only
place setting it, does this break any code that depends on layer->name
being populated?