|WARNING| [v2] config/arm: add Marvell CN20k

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172353

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-02

# DPDK Patch Review

## Analysis

This patch adds cross-compilation support for Marvell CN20k SoC, which is based on ARM Neoverse N3 cores. The changes involve adding a new meson cross-file and SoC configuration entry.

### Correctness Review

No correctness bugs identified. The patch:
- Adds a new configuration file without introducing executable code
- Defines configuration values that are straightforward (platform name, CPU family, endianness, etc.)
- Does not introduce resource management, memory operations, or control flow that could have bugs

### Style and Process Review

**Warning-level issues:**

1. **Missing release notes update** (Warning)

The patch adds a new platform/SoC configuration without updating the release notes. According to AGENTS.md guidelines, "New drivers or subsystems must have release notes." While this is not strictly a driver, adding support for a new SoC platform is a significant change that should be documented in `doc/guides/rel_notes/release_X_XX.rst` (where X_XX is the current release version). 

Suggested fix: Add a note to the current release notes under a section like "New Features" or "Supported Platforms":
```rst
* **Added Marvell CN20k SoC support**

  Added cross-compilation configuration for Marvell OCTEON 20 SoC
  based on ARM Neoverse N3 cores.
```

### Code Quality

The configuration values appear appropriate:
- `RTE_MAX_LCORE` set to 42 cores
- `RTE_MAX_NUMA_NODES` set to 1 (consistent with `'numa': false`)
- Part number `0xd8e` corresponds to ARM Neoverse N3 (per ARM documentation)
- CPU specification `armv9.2-a` is correct for Neoverse N3

The meson.build changes follow existing patterns for other SoCs (cn9k, cn10k, cobalt100).

### Formatting

- Meson file uses 4-space indentation (correct for meson files)
- Lists are alphabetically ordered
- Style is consistent with existing entries

### Additional Observations

The cross-file follows the existing pattern for other Marvell OCTEON SoCs and includes standard toolchain configuration. No issues with the technical content.

---

## Summary

The patch is technically sound but requires a release notes update to document the new platform support.

Review-Result: WARNING