|WARNING| [v3] net/i40e: add IEEE1588 handling to AVX vector paths

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172354

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-02

# DPDK Patch Review: net/i40e IEEE1588 vector path support

## ERRORS

None identified.

## WARNINGS

### Missing release notes

This patch adds significant new functionality (IEEE1588 support in AVX2/AVX512 vector paths) that affects driver capabilities and user-visible behavior. The release notes in `doc/guides/rel_notes/` should be updated to document this enhancement.

The change enables IEEE1588 timesync on previously unsupported code paths, which is a feature addition that users should be made aware of.

## INFO

### Code quality observations

**Positive aspects:**
- The implementation follows the existing FDIR pattern consistently
- Proper use of `#ifdef RTE_LIBRTE_IEEE1588` guards
- Comments explain the approach clearly
- The scattered packet fix in `rx.h` correctly propagates the `timesync` field
- Conditional store optimization using `_mm256_testz_si256()` avoids unnecessary writes

**Architecture-specific handling:**
The condition check correctly restricts IEEE1588 vector support to x86 (AVX2/AVX512), with a clear comment explaining why other architectures still require scalar paths. This is appropriate given the patch only implements x86 vector intrinsics.

**Timesync index extraction:**
The eight individual `_mm256_extract_epi32()` calls to populate `timesync` fields are somewhat verbose but match the FDIR ID extraction pattern already present in the code. This consistency is valuable for maintainability.

Review-Result: WARNING