|WARNING| net/crc: use static constants for SSE42 PCLMULQDQ parameters

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172730

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-08

# DPDK Patch Review

## Errors

None.

## Warnings

1. **Missing release notes update** (Warning):
   This patch changes the internal implementation of the CRC computation (removes runtime initialization, changes data structure layout) in a library component. While the external API remains unchanged, the change is significant enough that it should be documented in the current release notes under the "Libraries" section to note the initialization overhead reduction.

## Info

1. **Empty init function** (Info):
   After this change, `rte_net_crc_sse42_init()` becomes an empty function that does nothing. Consider removing it entirely if there are no other callers that depend on its existence, or add a comment explaining why it is retained as a no-op.

2. **Endianness of constants** (Info):
   The uint64_t array initialization with constants assumes little-endian byte order when loaded via `_mm_load_si128()`. The original code using `_mm_set_epi64x(k2, k1)` had the same assumption. This is acceptable for x86/SSE4.2-specific code but is worth noting that the constants are still platform-dependent.

3. **Code quality improvement acknowledged** (Info):
   The patch successfully achieves its stated goals: eliminates runtime initialization overhead, reduces data segment usage, and makes the constants compile-time constant. The aligned load is explicit and correct given the `__rte_aligned(XMM_SIZE)` attribute on the structure definition.

---

Review-Result: WARNING