|WARNING| net/crc: use static constants for SSE42 PCLMULQDQ parameters

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172730

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-08

# DPDK Patch Review

## Errors

None identified.

## Warnings

### 1. Empty function body after removing initialization code

`rte_net_crc_sse42_init()` becomes an empty function after this patch:

```c
void
rte_net_crc_sse42_init(void)
{
}
```

If this initialization function is no longer needed because the constants are now compile-time initialized, consider removing it entirely along with its callers, or documenting why an empty function is retained (e.g., for API stability).

### 2. `static const` context structures placed in handler functions

The `static const struct crc_pclmulqdq_ctx` structures are defined inside the handler functions `rte_crc16_ccitt_sse42_handler()` and `rte_crc32_eth_sse42_handler()`:

```c
static const struct crc_pclmulqdq_ctx crc16_ccitt_pclmulqdq = {
    .rk1_rk2 = { 0x14ff2LLU, 0x19a3cLLU },
    /* ... */
};
```

While this is functionally correct (the structures are compile-time constant and have function scope), consider moving them to file scope for clarity and to match the original pattern where they were file-scope variables. This would also make the intent clearer: these are shared constants used by the handlers, not function-local temporaries.

## Info

### Code simplification achieved

The patch successfully eliminates runtime initialization of SIMD constants by using `uint64_t[2]` arrays that can be compile-time initialized, then loading them with explicit `_mm_load_si128()`. This is a valid approach that removes the need for `rte_net_crc_sse42_init()` to populate the values.

The alignment attribute on the context structure (`__rte_aligned(XMM_SIZE)`) ensures the arrays can be safely loaded with aligned SIMD instructions.

Review-Result: WARNING