|SUCCESS| [2/2] net/ice: fix DCF minimum API version log

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172735

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-09

# DPDK Patch Review

## PATCH 1/2: net/iavf: fix minimum API version log

### Analysis

This patch fixes a copy-paste error in an error log message. The code was using `VIRTCHNL_VERSION_MAJOR_START` for both the major and minor version format arguments, causing the log to print the major version number twice instead of major.minor.

**Evidence:**
```c
/* Before (line 780-781): */
PMD_INIT_LOG(ERR, "VIRTCHNL API version should not be lower"
             " than (%u.%u) to support Adaptive VF",
             VIRTCHNL_VERSION_MAJOR_START,
-            VIRTCHNL_VERSION_MAJOR_START);
+            VIRTCHNL_VERSION_MINOR_START);
```

The fix correctly passes `VIRTCHNL_VERSION_MINOR_START` as the second argument.

**Verification:** This is purely a logging fix. The conditional logic above the log message (lines 775-777, visible in context) already uses the correct major and minor constants for the actual version check, so only the log message was wrong.

No issues found.

---

## PATCH 2/2: net/ice: fix DCF minimum API version log

### Analysis

This patch fixes the identical copy-paste error in the ice DCF code. The pattern is the same: `ICE_CPF_VIRTCHNL_VERSION_MAJOR_START` was used for both format arguments.

**Evidence:**
```c
/* Before (line 335-337): */
PMD_INIT_LOG(ERR,
             "VIRTCHNL API version should not be lower than (%u.%u)",
             ICE_CPF_VIRTCHNL_VERSION_MAJOR_START,
-            ICE_CPF_VIRTCHNL_VERSION_MAJOR_START);
+            ICE_CPF_VIRTCHNL_VERSION_MINOR_START);
```

The fix correctly uses `ICE_CPF_VIRTCHNL_VERSION_MINOR_START` as the minor version argument.

**Verification:** The conditional logic at lines 329-333 (visible in context) correctly uses separate major and minor constants for the actual version check, confirming only the log was wrong.

No issues found.

---

## Summary

Both patches fix identical logging bugs where error messages would print the major version number twice instead of "major.minor". These are correct, minimal fixes with no impact on functionality--the version checks themselves were already correct, only the diagnostic output was wrong.

- No correctness bugs introduced or missed
- No style violations
- No API changes (logging output only)
- No documentation needed (internal error messages)
- Appropriate for stable backport (fixes user-visible diagnostic output)

Review-Result: CLEAN