|SUCCESS| [2/2] net/ice: fix DCF minimum API version log

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172735

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-09

# DPDK Patch Review

## Patch 1/2: net/iavf: fix minimum API version log

### Analysis

This patch fixes a copy-paste error in an error message where the minor version parameter was incorrectly using `VIRTCHNL_VERSION_MAJOR_START` instead of `VIRTCHNL_VERSION_MINOR_START`.

**Evidence:**
```c
/* Before (line 780-781) */
PMD_INIT_LOG(ERR, "VIRTCHNL API version should not be lower"
             " than (%u.%u) to support Adaptive VF",
             VIRTCHNL_VERSION_MAJOR_START,
             VIRTCHNL_VERSION_MAJOR_START);  /* Wrong: major used twice */

/* After */
PMD_INIT_LOG(ERR, "VIRTCHNL API version should not be lower"
             " than (%u.%u) to support Adaptive VF",
             VIRTCHNL_VERSION_MAJOR_START,
             VIRTCHNL_VERSION_MINOR_START);  /* Correct: minor version */
```

This is purely a logging fix - the comparison logic itself is unaffected. The error message would have displayed the wrong minimum minor version number to users (repeating the major version instead), but this does not affect program correctness.

**Findings:** None. This is a correct bug fix.

---

## Patch 2/2: net/ice: fix DCF minimum API version log

### Analysis

This patch fixes the identical copy-paste error in the ICE DCF driver's API version check error message.

**Evidence:**
```c
/* Before (line 336-337) */
PMD_INIT_LOG(ERR,
             "VIRTCHNL API version should not be lower than (%u.%u)",
             ICE_CPF_VIRTCHNL_VERSION_MAJOR_START,
             ICE_CPF_VIRTCHNL_VERSION_MAJOR_START);  /* Wrong: major used twice */

/* After */
PMD_INIT_LOG(ERR,
             "VIRTCHNL API version should not be lower than (%u.%u)",
             ICE_CPF_VIRTCHNL_VERSION_MAJOR_START,
             ICE_CPF_VIRTCHNL_VERSION_MINOR_START);  /* Correct: minor version */
```

Same as patch 1/2: this is a logging fix only. The error message would display an incorrect minimum version number, but the actual version comparison logic remains correct.

**Findings:** None. This is a correct bug fix.

---

## Series-Level Review

### Correctness
- No resource leaks, use-after-free, or race conditions
- No logic errors introduced
- Both patches fix display-only bugs (wrong log output) without affecting control flow

### Style and Guidelines
- Code formatting is consistent with surrounding code
- No forbidden tokens introduced
- No API changes
- No ABI impact
- Cc: stable at dpdk.org is correctly present for backportable fixes

### Documentation
- No documentation changes needed (logging fixes only)
- No release notes needed (these are internal driver logging corrections, not API changes or user-visible feature/behavior changes)

### Process
- Fixes tags are present and correctly formatted
- Changes are minimal and focused
- Each patch is independent and compilable

---

Review-Result: CLEAN