|WARNING| net: add special-purpose MPLS label values

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Tue Nov 10 12:03:04 CET 2026


Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172795

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-10

# DPDK Patch Review

## Errors

None identified.

## Warnings

**Missing release notes update**

The patch adds new public API macros (`RTE_MPLS_LABEL_*`) to an installed header (`lib/net/rte_mpls.h`), which constitutes a change to the public API. Such changes require an update to the release notes in `doc/guides/rel_notes/`.

**Suggested fix:**
Add a section to `doc/guides/rel_notes/release_26_11.rst` (or the current release notes file) under "New Features" documenting these new MPLS label definitions:

```rst
* **Added MPLS special-purpose label value definitions.**

  Added macro definitions for IANA-registered special-purpose MPLS label values
  in ``rte_mpls.h``, including IPv4/IPv6 Explicit NULL, Router Alert, Entropy
  Label Indicator, and other standard labels from RFC 3032, RFC 6790, RFC 9994,
  and related specifications.
```

## Info

**Comment formatting suggestion**

The multi-line comment introducing the special-purpose labels follows the correct DPDK style. However, for consistency with other header files, consider whether this would be better as a Doxygen block comment (`/** ... */`) since it documents public API constants. This is purely a stylistic consideration and the current format is acceptable.

**Copyright year**

The patch adds "Copyright(c) 2026 SmartShare Systems" which reflects when this code was written. This is acceptable per DPDK guidelines (copyright years reflect authorship time, not subject to AI review per the guidelines).

**Macro naming and consistency**

The naming convention is consistent with DPDK standards: all macros use the `RTE_` prefix, are ALL_UPPERCASE, and follow a logical pattern (`RTE_MPLS_LABEL_<name>`). The comment distinguishing Extended Special-Purpose labels clearly indicates the context where labels 16-18 are valid.

**Technical correctness**

The label values and their descriptions match the IANA registry and the referenced RFCs. The distinction between base special-purpose labels (0-15) and extended labels (16+, valid after XL) is correctly noted in the comment.

Review-Result: WARNING


More information about the test-report mailing list