|WARNING| net: add special-purpose MPLS label values
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Tue Nov 10 12:13:34 CET 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172795
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-10
# DPDK Patch Review
## ERRORS
None identified.
## WARNINGS
**Warning 1: Missing release notes**
The patch adds new public API macros (`RTE_MPLS_LABEL_*`) to an installed header (`lib/net/rte_mpls.h`).
According to the guidelines, API changes require release notes.
The current release notes file (for 26.11 based on the patch date) should document these additions.
Example release notes entry:
```rst
* **net: Added MPLS special-purpose label value definitions.**
Added macros for IANA-assigned special-purpose MPLS label values:
``RTE_MPLS_LABEL_IPV4``, ``RTE_MPLS_LABEL_ROUTER_ALERT``,
``RTE_MPLS_LABEL_IPV6``, ``RTE_MPLS_LABEL_NULL``, ``RTE_MPLS_LABEL_MNA``,
``RTE_MPLS_LABEL_ELI``, ``RTE_MPLS_LABEL_GAL``, ``RTE_MPLS_LABEL_OAM_ALERT``,
``RTE_MPLS_LABEL_XL``, ``RTE_MPLS_LABEL_MLI``, ``RTE_MPLS_LABEL_MPI``,
and ``RTE_MPLS_LABEL_FLI``.
```
**Warning 2: Missing Doxygen documentation**
Public API macros should have Doxygen comments describing their purpose.
While the inline comments reference RFCs (which is good),
they should use the `/** ... */` Doxygen format for consistency with DPDK documentation standards.
Suggested format:
```c
/** IPv4 Explicit NULL Label (RFC 3032). */
#define RTE_MPLS_LABEL_IPV4 0
/** Router Alert Label (RFC 3032). */
#define RTE_MPLS_LABEL_ROUTER_ALERT 1
```
This allows the API documentation to be generated automatically and indexed properly.
## INFO
None.
---
Review-Result: WARNING
More information about the test-report
mailing list