|WARNING| net: add special-purpose MPLS label values

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Tue Nov 10 12:16:34 CET 2026


Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172795

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-10

# DPDK Patch Review

## Patch: net: add special-purpose MPLS label values

### ERRORS

None identified.

### WARNINGS

**1. Missing release notes update**

This patch adds new public API macros but does not update the release notes in `doc/guides/rel_notes/`.

**Suggested fix:**
Add a release notes entry in the current release notes file under "New Features" section, similar to:
```rst
* **Added MPLS special-purpose label value definitions.**

  Added macros defining IANA-standardized special-purpose MPLS label values
  to ``rte_mpls.h``, including IPv4/IPv6 explicit NULL labels, router alert,
  entropy label indicator, and extended label values.
```

**2. Missing Doxygen documentation for public macros**

The new macros are public API but lack Doxygen documentation. While they have inline comments with RFC references, proper Doxygen format would be more consistent with DPDK style.

**Suggested fix:**
Convert inline comments to Doxygen format:
```c
/** IPv4 Explicit NULL Label (RFC 3032). */
#define RTE_MPLS_LABEL_IPV4         0
/** Router Alert Label (RFC 3032). */
#define RTE_MPLS_LABEL_ROUTER_ALERT 1
```

### INFO

**Copyright year accuracy**

The patch adds a 2026 copyright for SmartShare Systems. Ensure this reflects when the contribution was actually created. If this code was written in an earlier year, the copyright should reflect that year.

**API stability consideration**

These are new macro definitions in an existing header. While they don't require `__rte_experimental` (macros are not subject to experimental tagging), they will become part of the stable ABI. The values appear to be standardized by IANA, so they should be stable, but verify the RFC references are final/published standards and not drafts.

Review-Result: WARNING


More information about the test-report mailing list