|WARNING| net/ice: fix max number of descriptors for E830

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170850

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-08

# DPDK Patch Review

## Patch Summary
This patch fixes descriptor limit handling for Intel E830 NICs. The driver was advertising up to 8160 descriptors but E830 hardware only supports 8096, which could cause queue length field overflow and trigger Malicious Driver Detection events when Tx packet pacing is enabled.

---

## Correctness Issues

### No correctness bugs found

The patch correctly addresses the mismatch between advertised limits and hardware capabilities. All changed paths now consistently use `ICE_MAX_NUM_DESC_BY_MAC(hw)` which returns the appropriate limit based on MAC type.

**Verified paths:**
- `dev_info->rx_desc_lim.nb_max` - now matches hardware capability
- `dev_info->tx_desc_lim.nb_max` - now matches hardware capability  
- `dev_info->tx_desc_lim.nb_seg_max` - now matches hardware capability
- `ice_rx_queue_setup()` validation - now rejects values hardware cannot support
- `ice_tx_queue_setup()` validation - now rejects values hardware cannot support

No resource leaks, use-after-free, or synchronization issues are introduced. The change is purely a limit correction.

---

## Code Style

### No style violations found

- Indentation and formatting are consistent with existing code
- No forbidden tokens introduced
- No trailing whitespace
- Changes follow existing patterns in the driver

---

## API and Documentation

### Warning: Missing release notes update

**Issue:** This bug fix changes the advertised descriptor limits for E830 devices, which is a behavioral change visible to applications. The patch includes `Cc: stable at dpdk.org` indicating it should be backported, but does not update release notes.

**Impact:** Applications querying device info on E830 will see `nb_max` change from 8160 to 8096 for Rx and Tx descriptors.

**Recommendation:** Add a release note entry documenting the bug fix and the corrected descriptor limit for E830. Example:

```rst
* **Fixed descriptor limit for Intel E830 NICs.**

  Corrected the maximum number of descriptors per ring for E830 devices
  from 8160 to 8096 to match hardware capability. This prevents queue
  length overflow when Tx packet pacing is enabled.
```

---

## Summary

**Errors:** 0  
**Warnings:** 1 (missing release notes)  
**Info:** 0

The patch is technically correct and fixes a real bug that could cause hardware exceptions. The only issue is the missing release notes documentation for the behavioral change.