|WARNING| net/ice: fix max number of descriptors for E830

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170850

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-08

# DPDK Patch Review

## Summary
This patch fixes descriptor limits for Intel E830 NICs to match hardware capabilities and prevent Malicious Driver Detection events. The changes are straightforward substitutions of a constant with a hardware-dependent macro.

---

## Errors

None identified.

---

## Warnings

### 1. Missing validation test
**Location:** Overall patch

The patch fixes a bug where E830 could accept up to 8160 descriptors but only supports 8096, leading to MDD events when Tx packet pacing is enabled. However, there's no test case added to verify:
- That E830 correctly rejects >8096 descriptors
- That the MDD event no longer occurs at the boundary
- That other MAC types still accept their correct maximum

**Suggested fix:** Add a test case in `app/test` or document manual testing performed for this fix.

---

### 2. Release notes not updated
**Location:** N/A (missing file modification)

This is a significant bug fix that changes advertised device capabilities and resolves MDD events. It should be documented in the current release notes under "Bug Fixes" or "net/ice" section.

**Suggested fix:** Add an entry to `doc/guides/rel_notes/release_XX_XX.rst`:
```rst
* **net/ice: Fixed descriptor limits for E830.**

  Fixed advertised descriptor limits for E830 to match hardware maximum
  of 8096 descriptors. Previously the driver allowed configuring up to
  8160 descriptors, which could trigger Malicious Driver Detection events
  when Tx packet pacing was enabled.
```

---

## Info

### Code correctness
The patch correctly:
- Uses `ICE_MAX_NUM_DESC_BY_MAC(hw)` consistently across all three locations where descriptor limits are checked or advertised
- Maintains alignment with the existing ring allocation code which already used this macro
- Preserves the fix semantics: E830 gets 8096, other devices get their appropriate maximum

### Style compliance
- No forbidden tokens introduced
- No style violations observed
- Consistent with existing code patterns in the modified functions

### Scope appropriateness
The fix is minimal and targeted:
- Only changes the descriptor limit checks/advertisements
- Does not alter allocation logic (already correct)
- Changes are confined to ice driver

---

## Recommendation

**Approve with minor improvements:**
1. Add test coverage or document testing performed
2. Update release notes

The core correctness fix is sound. The missing elements are process/documentation items that should be addressed before merge.