|SUCCESS| drivers/dma: cleanup PCI probing in Intel drivers
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Oct 9 14:41:01 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/170971
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-09
# DPDK Patch Review
## Patch: drivers/dma: cleanup PCI probing in Intel drivers
### Summary
This patch removes redundant driver reference assignments from Intel DMA drivers (idxd and ioat), as this assignment is now handled by the EAL bus layer. The patch also marks the now-unused `drv` parameter with `__rte_unused`.
---
## Findings
### Errors
None.
### Warnings
None.
### Info
**1. Consistent pattern with EAL factorization**
The removal of `dev->device.driver = &drv->driver;` assignments is correct. The referenced commit `f282771a04ef` moved this responsibility to the bus layer, making these assignments redundant. The pattern is consistent across both modified drivers.
**2. Parameter annotation**
The addition of `__rte_unused` to the `drv` parameter is the correct way to handle a parameter that became unused after the refactor. This silences compiler warnings about unused parameters while maintaining function signature compatibility with the PCI driver probe callback type.
**3. Code simplification**
The patch correctly simplifies the probe functions by removing boilerplate code that is now handled centrally. This reduces the maintenance burden on individual drivers.
---
## Conclusion
The patch is correct and follows DPDK coding standards. It properly cleans up redundant code after an EAL factorization change. No issues found.
More information about the test-report
mailing list