|SUCCESS| drivers/dma: cleanup PCI probing in Intel drivers

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/170971

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-09

# Review of DPDK Patch: drivers/dma: cleanup PCI probing in Intel drivers

## Summary

This patch removes redundant driver reference assignments from two Intel DMA drivers (idxd and ioat). The changes are correct and align with the EAL factorization of driver references. No correctness bugs or style violations were found.

## Findings

### Info

**Parameter marked `__rte_unused` without removal of parameter name**

In both modified functions, the `drv` parameter is marked `__rte_unused` but the parameter name is retained:

```c
// drivers/dma/idxd/idxd_pci.c:326
idxd_dmadev_probe_pci(struct rte_pci_driver *drv __rte_unused, struct rte_pci_device *dev)

// drivers/dma/ioat/ioat_dmadev.c:717  
ioat_dmadev_probe(struct rte_pci_driver *drv __rte_unused, struct rte_pci_device *dev)
```

**Consideration:** While `__rte_unused` is appropriate and the code is correct, a more concise style would be to omit the parameter name entirely:

```c
idxd_dmadev_probe_pci(struct rte_pci_driver *drv __rte_unused, struct rte_pci_device *dev)
// Could be:
idxd_dmadev_probe_pci(struct rte_pci_driver *, struct rte_pci_device *dev)
```

However, keeping the parameter name can aid readability and is acceptable practice. This is a minor style preference, not a requirement.

---

## Verification Checklist

- [x] No correctness bugs (use-after-free, resource leaks, race conditions)
- [x] No forbidden tokens
- [x] Proper use of comparison operators (N/A - no comparisons added)
- [x] No deprecated API usage
- [x] Consistent code style
- [x] No ABI changes
- [x] Fixes tag present and appropriate
- [x] No documentation changes required (internal driver cleanup)
- [x] No release notes required (internal refactoring per EAL change)

## Conclusion

**The patch is correct and ready for integration.** The removal of `dev->device.driver = &drv->driver;` assignments is appropriate following the EAL factorization commit referenced in the Fixes tag. The addition of `__rte_unused` to the `drv` parameter correctly silences compiler warnings about the unused parameter while maintaining the required function signature for the PCI driver probe callback.