|WARNING| [2/2] lib: remove stack from always enabled libraries

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171379

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-14

# DPDK Patch Review

## Patch 1/2: lib: remove cmdline from always enabled libraries

### Analysis

The patch removes `cmdline` from the `always_enable` list in `lib/meson.build`.

**Verification of claim:**
The commit message states that cmdline is not used by any driver or library (excluding app/ and examples/), and provides grep output showing only self-references within cmdline itself and buildtools.

**Correctness:**
- The change is purely a build system modification removing a library from auto-enable
- No code changes that could introduce bugs
- The library remains available, just not automatically enabled

**Process compliance:**
- Missing release notes update for this build system change that affects library availability

**Severity assessment:**
This is a build system change that may affect users who implicitly depend on cmdline being always available. Release notes should document this.

---

## Patch 2/2: lib: remove stack from always enabled libraries

### Analysis

The patch removes `stack` from the `always_enable` list in `lib/meson.build`.

**Verification of claim:**
The commit message states that rte_stack is only used by the mempool stack driver and stack tests, providing grep output showing three usage locations all with explicit dependencies.

**Correctness:**
- The change is purely a build system modification removing a library from auto-enable
- No code changes that could introduce bugs
- The library remains available, just not automatically enabled

**Process compliance:**
- Missing release notes update for this build system change that affects library availability

**Severity assessment:**
This is a build system change that may affect users who implicitly depend on stack being always available. Release notes should document this.

---

## WARNINGS

**Patch 1/2:**
- Missing release notes update. Changes to library availability in the build system should be documented in the current release notes file under a "Removed Items" or "Build System" section. Users who implicitly relied on cmdline being always available need to know they must now explicitly enable it.

**Patch 2/2:**
- Missing release notes update. Changes to library availability in the build system should be documented in the current release notes file under a "Removed Items" or "Build System" section. Users who implicitly relied on stack being always available need to know they must now explicitly enable it.

---

Review-Result: WARNING