|WARNING| [2/2] lib: remove stack from always enabled libraries

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171379

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-15

# Review of DPDK Patch Series

## PATCH 1/2: lib: remove cmdline from always enabled libraries

### Analysis

This patch removes `cmdline` from the `always_enable` list in `lib/meson.build`.

**Verification of claim:**
The patch asserts that cmdline is only used in `app/` and `examples/` directories. The provided grep output supports this claim - no drivers or libraries (excluding cmdline itself) include cmdline headers.

**Correctness:**
- The change is a build system modification only
- No code changes that could introduce bugs
- The library remains available, just not force-enabled

**Process compliance:**
- Release notes are required for this change as it affects the build system and could impact users
- This is a build system behavior change that should be documented

### Findings

**WARNING:**
Release notes update missing. This patch changes build system behavior by making the cmdline library optional (no longer force-enabled). Users who depend on cmdline being implicitly available will need to explicitly enable it. This should be documented in the current release notes under a "Build System" or "Libraries" section.

---

## PATCH 2/2: lib: remove stack from always enabled libraries

### Analysis

This patch removes `stack` from the `always_enable` list in `lib/meson.build`.

**Verification of claim:**
The grep output shows stack is only used by:
- `app/test/test_stack.c` (test code)
- `app/test/test_stack_perf.c` (test code)  
- `drivers/mempool/stack/rte_mempool_stack.c` (mempool driver)

All these already have explicit dependencies declared.

**Correctness:**
- Build system change only
- No code changes that could introduce bugs
- Library remains available, just not force-enabled

**Process compliance:**
- Release notes are required for this change

### Findings

**WARNING:**
Release notes update missing. This patch changes build system behavior by making the stack library optional (no longer force-enabled). Users who depend on stack being implicitly available will need to explicitly enable it. This should be documented in the current release notes under a "Build System" or "Libraries" section.

---

## Series-Level Observations

Both patches follow the same pattern: removing libraries from `always_enable` where those libraries have no in-tree consumers outside `app/` and `examples/`. The changes are safe from a code perspective but represent a build system behavior change that affects users.

The series is well-constructed:
- Each patch is independent and focused on a single library
- The commit messages clearly state the rationale
- The grep evidence supports the claims

However, both patches lack the required release notes updates for build system changes.

---

Review-Result: WARNING