|WARNING| [2/2] meson: add drivers to dynamic libraries
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Thu Oct 15 12:50:02 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171403
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-15
# DPDK Patch Review
## PATCH 1/2: meson: rename static drivers list
### ERRORS
None identified.
### WARNINGS
None identified.
### INFO
None identified.
---
## PATCH 2/2: meson: add drivers to dynamic libraries
### ERRORS
None identified.
### WARNINGS
**Missing release notes update**
This patch changes the build system behavior when DPDK is used as a meson subproject with shared libraries, affecting how driver dependencies are collected. This is a functional change that should be documented in the release notes under the build system or compatibility section.
Suggested fix: Add a release notes entry to `doc/guides/rel_notes/release_XX_XX.rst` documenting that drivers installing public headers are now properly included in `dpdk_shared_lib_deps` when building as a meson subproject.
---
## OVERALL ASSESSMENT
Both patches are clean refactoring/build system fixes with no correctness issues.
**Patch 1/2** is purely a variable rename with no functional change - all usages are consistently updated.
**Patch 2/2** fixes a build dependency issue where drivers with public headers (bus/pci, bus/vdev) were not being included in the shared library dependency list when DPDK is built as a meson subproject. The logic mirrors the existing pattern for libraries and is guarded by the same `headers.length() > 0` check used in `lib/meson.build`.
The only issue is the missing release notes update for the functional change in patch 2/2.
Review-Result: WARNING
More information about the test-report
mailing list