|WARNING| [2/2] meson: add drivers to dynamic libraries

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Thu Oct 15 12:55:01 CEST 2026


Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171403

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-15

I have reviewed the patches against the DPDK coding guidelines. Here is my analysis:

## Patch 1/2: meson: rename static drivers list

This patch renames the `dpdk_drivers` variable to `dpdk_static_drivers` across multiple meson files to better reflect that it contains static driver libraries.

**No issues found.** The patch is a straightforward mechanical rename that improves clarity. All usages are consistently updated.

## Patch 2/2: meson: add drivers to dynamic libraries

This patch adds driver shared dependencies to `dpdk_shared_lib_deps` when drivers install public headers, mirroring the pattern used for libraries.

### ERROR

**Missing release notes for behavior change**

The patch changes link behavior for DPDK built as a meson subproject with shared libraries. This is a functional change that affects how drivers with public headers (bus/pci, bus/vdev) are linked when DPDK is used as a subproject. According to AGENTS.md:

> Changes to API require release notes
> New drivers or subsystems must have release notes

And from "Documentation" section:

> Update release notes in `doc/guides/rel_notes/` for important changes

This build system behavior change should be documented in the current release notes to inform users building DPDK as a meson subproject.

**Suggested fix**: Add a note to `doc/guides/rel_notes/release_26_03.rst` (or the current release) under "Build System Changes" or similar:

```rst
* **Fixed driver linking when DPDK is used as meson subproject.**

  When building DPDK as a shared library meson subproject, drivers that install
  public headers (such as bus/pci and bus/vdev) are now correctly included in
  ``dpdk_shared_lib_deps``, ensuring proper linkage for downstream projects.
```

Review-Result: ERROR


More information about the test-report mailing list