|WARNING| [v2,2/2] meson: add drivers to dynamic libraries

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Thu Oct 15 15:00:08 CEST 2026


Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171410

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-15

# DPDK Patch Review

## PATCH 1/2: meson: rename static drivers list

### Errors

None.

### Warnings

None.

### Info

None.

---

## PATCH 2/2: meson: add drivers to dynamic libraries

### Errors

**Missing release notes update**

This patch changes the DPDK build system behavior by adding driver shared libraries
to `dpdk_libraries` and `dpdk_shared_lib_deps`, which affects how DPDK is consumed
when built as a meson subproject with shared libraries.
This is a significant change that should be documented in the release notes
(`doc/guides/rel_notes/release_26_03.rst` or similar).

The addition to `dpdk_libraries` may also affect pkg-config file generation
and the list of libraries returned by `pkg-config --libs libdpdk`.
Describe the change and its impact so users understand
what this fixes and how driver dependencies are now handled.

```diff
diff --git a/doc/guides/rel_notes/release_26_03.rst b/doc/guides/rel_notes/release_26_03.rst
--- a/doc/guides/rel_notes/release_26_03.rst
+++ b/doc/guides/rel_notes/release_26_03.rst
@@ -XX,6 +XX,12 @@ New Features
 
 **Build system changes**
 
+* Fixed DPDK meson subproject builds with shared libraries to correctly
+  link against drivers that install public headers (e.g., bus/pci, bus/vdev).
+  Drivers with public headers are now included in `dpdk_shared_lib_deps`,
+  ensuring dependent projects can link properly when consuming DPDK
+  as a subproject.
+
 Removed Items
 -------------
```

---

## Summary

Patch 1/2 is a clean mechanical rename with no functional changes.

Patch 2/2 fixes a real build issue (missing driver dependencies in meson subproject builds)
but lacks release notes documentation for a behavior change that affects how DPDK is consumed
by downstream projects.

Review-Result: WARNING


More information about the test-report mailing list