|WARNING| [v2,2/2] meson: add drivers to dynamic libraries

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171410

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-15

# DPDK Patch Review

## PATCH 1/2: meson: rename static drivers list

No issues found. This is a straightforward variable rename that improves clarity by reflecting that the list contains static driver libraries specifically.

## PATCH 2/2: meson: add drivers to dynamic libraries

### ERRORS

**drivers/meson.build:408** - Logic error in conditional driver inclusion

The patch adds driver shared libraries to `dpdk_libraries` and `dpdk_shared_lib_deps` only when `headers.length() > 0`. This creates an inconsistency: static drivers are unconditionally added to `dpdk_static_drivers` at line 407, but shared drivers are conditionally added based on whether they install headers.

This means that when building with `default_library='shared'`, driver libs without public headers will be missing from dependency declarations, even though they are built and may be needed. The conditional should match the static case or be justified by actual dependency requirements.

```diff
         dpdk_static_drivers += static_lib
-        if headers.length() > 0
+        # Add to shared lib deps unconditionally, matching static behavior
-            dpdk_libraries += shared_lib
-            dpdk_shared_lib_deps += shared_dep
-        endif
+        dpdk_libraries += shared_lib
+        dpdk_shared_lib_deps += shared_dep
```

If the header-based condition is intentional (only drivers with public headers need to be in the shared dependency list), this needs either:
1. A comment explaining why, or
2. The same condition applied to the static case for consistency

Without reading the full meson infrastructure and verifying what `dpdk_libraries` is used for, the asymmetry between static (unconditional) and shared (conditional) addition is a likely bug.

---

Review-Result: ERROR