|SUCCESS| [v1] net/mlx5: fix suffix groups without default FDB rule
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Oct 16 10:17:42 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171476
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-16
# DPDK Patch Review
## ERRORS
None identified.
## WARNINGS
None identified.
## INFO
**Conditional logic correctness:**
The patch changes the suffix group decrement condition from checking only `sfx_attr.transfer` to checking both `sfx_attr.transfer && priv->fdb_def_rule`. This ensures that suffix groups are only decremented when both transfer mode is active AND the default FDB rule is enabled. The logic appears correct for the stated purpose of preventing wrong table installation when `fdb_def_rule_en=0`.
**Consistent pattern:**
The same fix is applied to both `flow_create_split_meter()` (line 7051) and `flow_create_split_sample()` (line 7232), maintaining consistency across the two code paths that handle suffix group calculation.
**Code context:**
Both modifications are straightforward conditional changes that add an additional check (`&& priv->fdb_def_rule`) to existing transfer checks. The surrounding code structure and error handling remain unchanged.
Review-Result: CLEAN
More information about the test-report
mailing list