|SUCCESS| [v1] net/mlx5: fix suffix groups without default FDB rule

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Fri Oct 16 10:25:02 CEST 2026


Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171476

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-16

# Review of DPDK Patch: net/mlx5: fix suffix groups without default FDB rule

## ERRORS

None identified.

## WARNINGS

None identified.

## INFO

**Code correctness verified:**
The patch correctly makes suffix group decrement conditional on both `sfx_attr.transfer` and `priv->fdb_def_rule` being true. This prevents incorrect group-to-table translation when the default FDB rule is disabled via `fdb_def_rule_en=0`.

The change affects two locations:
1. Line 7051: meter suffix group calculation
2. Line 7232: sampler suffix group calculation

Both follow the same pattern and are logically consistent with the commit message's stated goal.

**Pre-existing observation (not introduced by this patch):**
The variable `sfx_tbl_data` at line 7229 is assigned but only used for reading `level` twice on lines 7232-7233. The container_of macro and dereference could potentially be done inline, but this is a minor style observation about existing code structure.

Review-Result: CLEAN


More information about the test-report mailing list