|SUCCESS| [v2] net/bnxt: remove unused TruFlow debug dump helpers
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Tue Oct 20 09:47:13 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171725
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-20
# DPDK Patch Review
## Summary
This patch removes unused debug dump helpers from the bnxt TruFlow v3 driver. The only function with an actual caller (`tfc_mpc_table_read()`) is moved to `tfc_em.c` unchanged. The removed code contained unbounded `strcat()` calls and format-string handling that caused clang build failures.
## ERRORS
None.
## WARNINGS
None.
## INFO
**Pre-existing issue in moved code (not introduced by this patch):**
The `tfc_mpc_table_read()` function that is moved from `tfc_mpc_debug.c` to `tfc_em.c` contains logging statements that use `PMD_DRV_LOG_LINE(ERR, ...)` to emit information that is not an error (line ~740 in the moved code):
```c
PMD_DRV_LOG_LINE(ERR,
"Debug read table type:%s %d words32B at way:%d set:%d debug:%d words32B",
(type == 0 ? "Lookup" : "Action"),
words, way, set, debug);
else
PMD_DRV_LOG_LINE(ERR,
"Reading table type:%s %d words32B at offset %d words32B",
(type == 0 ? "Lookup" : "Action"),
words, offset);
```
These appear to be informational messages logged at ERROR level. This is pre-existing (the code is moved unchanged from the deleted file) and does not affect correctness. A follow-up patch could change these to `INFO` or `DEBUG` level, or remove them if they are no longer needed.
---
Review-Result: CLEAN
More information about the test-report
mailing list