|SUCCESS| [v2] net/bnxt: remove unused TruFlow debug dump helpers

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171725

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-20

# Review of DPDK Patch: net/bnxt: remove unused TruFlow debug dump helpers

## Errors

None identified.

## Warnings

None identified.

## Info

### 1. Code Movement Without Modification

The patch moves `tfc_mpc_table_read()` from `tfc_mpc_debug.c` to `tfc_em.c` unchanged.
This is correct: the function is used by `tfc_em_delete_entries_by_pool_id()` in `tfc_em.c`,
and removing the debug file that previously housed it makes the move necessary.
The move does not introduce new code, so it does not require review for correctness
beyond verifying that the function retains its existing call site.

### 2. Deletion of Unused Debug Infrastructure

The patch removes:
- `tfc_debug.h` (header declaring unused debug helpers)
- `tfc_mpc_debug.c` (containing `tfc_mpc_table_read()` and unused debug functions)
- `tfc_tcam_debug.c` (TCAM debug dump helpers)

According to the commit message, the removed functions (`tfc_em_show()`, `tfc_wc_show()`,
`tfc_backing_store_dump()`, TCAM show/read helpers) are built unconditionally but never called.
The only function with a caller, `tfc_mpc_table_read()`, is preserved by moving it to `tfc_em.c`.

This is a cleanup patch addressing an observed clang -Werror build failure
(unbounded strcat() and format-string handling in the unused helpers).
Removing unused code is the correct fix.

### 3. File Removal from Build

The meson.build change removes:
```
-        'tfc_mpc_debug.c',
-        'tfc_tcam_debug.c',
```
These files are deleted, so removal from sources is correct.

Review-Result: CLEAN