|SUCCESS| [v2] net/bnxt: remove unused TruFlow debug dump helpers

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171725

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-20

# DPDK Patch Review

## Pass 1: Correctness Bugs

**Careful pass through the `tfc_mpc_table_read()` function that was moved:**

The function is moved unchanged from `tfc_mpc_debug.c` to `tfc_em.c`. Tracing through its error paths:

1. **Line 726-756**: Multiple early returns on errors (`-EINVAL`). Before each:
   - No allocations have occurred yet (all checked pointers are function parameters or fetched via `tfo_*` calls)
   - No cleanup needed on these early returns 

2. **Lines 779-884**: MPC command build, send, and parse. On error:
   - `goto cleanup` at lines 836, 851, 865, 877
   - The `cleanup:` label (line 886) just returns `rc`
   - No resources allocated between function entry and these error paths
   - No leaks 

3. **Successful path (line 884)**: Direct `return 0`, no allocated resources to clean up 

The moved function is correct.

**Deletion of unused code:**

The removed functions (`tfc_mpc_table_write_zero`, `tfc_mpc_table_invalidate`, `tfc_em_show`, `tfc_wc_show`, and all TCAM debug helpers) are stated to have no callers. The only function with a caller (`tfc_mpc_table_read()`) was moved. No correctness issues with the removal.

## Pass 2: Style/Process False Positives

None. The patch deletes code and moves one function unchanged. No style or process items to check.

## Pass 3: Evidence and Requirements

**Evidence check:**
- The patch removes two complete files (`tfc_mpc_debug.c`, `tfc_tcam_debug.c`) and one header (`tfc_debug.h`)
- It moves `tfc_mpc_table_read()` verbatim from `tfc_mpc_debug.c` to `tfc_em.c`
- The commit message states these are "unused debug dump routines" with no callers, except `tfc_mpc_table_read()` which is used by `tfc_em_delete_entries_by_pool_id()`. Confirmed: the moved function appears before that caller in `tfc_em.c` 
- meson.build updated to remove the deleted source files 

**API/ABI:**
- No public API is removed. The deleted functions are internal to the driver (`drivers/net/bnxt/tf_core/v3/`)
- `tfc_debug.h` was not an installed header (not listed in any `headers` or `indirect_headers`)
- No ABI impact 

**Documentation:**
- This is internal driver cleanup, no user-facing documentation needed 

**Release notes:**
- Internal cleanup, no release notes required 

## Severity Summary

No findings.

---

The patch is clean: it removes unused internal debug code and relocates the one called function to its consumer's file unchanged. No correctness bugs, no style violations, no process issues.

Review-Result: CLEAN