|SUCCESS| [v2] net/bnxt/tf_ulp: check EM key pad result

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171728

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-20

# DPDK Patch Review

## ERRORS

None.

## WARNINGS

None.

## INFO

None.

---

## Summary

This patch adds a missing error check for `ulp_blob_pad_push()` in `ulp_mapper_tfc_em_tbl_process()`. The function could previously fail silently when padding did not fit, causing the EM key length and result position to be computed incorrectly and malformed entries to be sent to hardware.

**Correctness**: The fix is correct. `ulp_blob_pad_push()` returns -1 on failure (when the requested padding exceeds available space), and ignoring this return value meant the blob write index remained at the wrong position. All other callers in the mapper already check this return value, making this an inconsistency fix as well as a correctness fix.

**Style compliance**:
- Uses `unlikely()` macro for the error path (consistent with DPDK fast-path conventions)
- Uses `BNXT_DRV_DBG(ERR, ...)` for error logging (consistent with the rest of the file)
- Returns `-EINVAL` (consistent with other `ulp_blob_pad_push()` failure handlers in the mapper)
- Explicit comparison `< 0` is used (compliant with DPDK style)

**Process compliance**:
- `Fixes:` tag present with commit hash
- `Cc: stable at dpdk.org` present (appropriate for a bug fix)
- Commit message clearly explains the bug and the fix

No issues found.

Review-Result: CLEAN