|SUCCESS| [v2] net/bnxt/tf_ulp: check EM key pad result

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171728

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-20

# DPDK Patch Review

## ERRORS

None identified.

## WARNINGS

None identified.

## INFO

**1. Patch correctness**

The patch correctly addresses a missing error check on `ulp_blob_pad_push()`. The function returns -1 when the requested padding does not fit in the blob, and ignoring this return value would cause incorrect key length calculation and a malformed EM entry to be sent to hardware. Adding the check and returning `-EINVAL` is the right fix and matches the pattern used elsewhere in the mapper.

**2. Code style compliance**

The error check follows the existing pattern in the file:
- Uses `unlikely()` as seen in other error paths in the same file
- Uses `BNXT_DRV_DBG(ERR, ...)` consistent with the driver's logging style
- Returns `-EINVAL` matching other validation failures in the mapper
- Follows the style of other `ulp_blob_pad_push()` call sites

**3. Process compliance**

- Properly tagged for stable (`Cc: stable at dpdk.org`)
- Includes `Fixes:` tag referencing the commit that introduced the issue
- Commit message clearly explains the bug and the fix

The patch is a clean bug fix with no style, API, or documentation issues.

Review-Result: CLEAN