|SUCCESS| common/mlx5: fix mkey ordering enum
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Thu Oct 22 10:22:00 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171825
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-22
# DPDK Patch Review
## Summary
This patch updates the `mlx5_mkc_raw_ordering` enum values to match the current device specification. The enum value for relaxed ordering is changed from 0x2 to 0x1, and the SAO (Store After Only) entry at 0x1 is removed.
## Errors
None identified.
## Warnings
None identified.
## Info
### Enum Value Removal May Break Existing Code
The `MLX5_MKC_RAW_ORDERING_SAO` enum value is being removed entirely. If this enum value is referenced anywhere in the codebase (drivers, tests, documentation), those references will fail to compile after this patch.
**Recommendation**: Before accepting this patch, verify that `MLX5_MKC_RAW_ORDERING_SAO` is not used anywhere in the DPDK tree. A simple grep would confirm:
```bash
git grep MLX5_MKC_RAW_ORDERING_SAO
```
If it is used, those call sites must be updated in the same patch or a preceding patch in the series to avoid breaking `git bisect`.
### Release Notes
Since this changes the values of a public enum (even though it's in a driver-specific header), consider adding a note to the release notes if this could affect applications that directly use these values (though this seems unlikely given it's mlx5-internal).
Review-Result: CLEAN
More information about the test-report
mailing list